Add Db#56
Open
tiep2999 wants to merge 6 commits into
Open
Conversation
update repo
update repo
update repo
quytm
reviewed
Jul 3, 2019
quytm
left a comment
quytm
left a comment
Contributor
There was a problem hiding this comment.
bị lặp lại mywallet-version-1, tuy nhiên a vẫn review code trong đó
| private CustomerService customerService; | ||
|
|
||
|
|
||
| @GetMapping(value = {"/", "Customer/list"}) |
Contributor
There was a problem hiding this comment.
url sửa thành viết thường nhé: customer/list
những url bên dưới cũng sửa tương tự
|
|
||
|
|
||
| /* | ||
| tìm name |
Contributor
There was a problem hiding this comment.
nếu muốn mô tả chi tiết function/method làm gì, cần đặt nó ở trước function/method
e đặt ở cuối file a k hiểu?
|
|
||
| Customer getOne(Long id); | ||
|
|
||
| void addCustomer(Customer contact); |
Contributor
There was a problem hiding this comment.
nên trả về dữ liệu Customer sau khi add nhé
| } | ||
|
|
||
| @Override | ||
| public Customer updateCustomer(Customer customerOld, Customer customerNew){ |
Contributor
There was a problem hiding this comment.
e tham khảo cách khác này nhé (cách cũ kia không sai, nhưng chả ai dùng):
- chỉ đẩy lên Customer (đã update dữ liệu)
- update trực tiếp Customer đó vào DB (vì id của customer không thay đổi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.