Skip to content

update description file#72

Merged
d-morrison merged 2 commits into
mainfrom
update-desc
Jun 5, 2026
Merged

update description file#72
d-morrison merged 2 commits into
mainfrom
update-desc

Conversation

@d-morrison

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1-2-g6ad689f
Preview removed because the pull request was closed.
2026-06-05 00:53 UTC

@d-morrison

Copy link
Copy Markdown
Member Author

@claude review

@claude

claude Bot commented Jun 3, 2026

Copy link
Copy Markdown

Claude finished @d-morrison's task in 58s —— View job


PR Review: update description file

  • Read CLAUDE.md for repo guidelines (no CLAUDE.md found)
  • Review DESCRIPTION file changes
  • Post review feedback

Review Summary

This PR makes three changes to the DESCRIPTION file: replaces placeholder author info with real authors, updates the roxygen2 version configuration, and removes the old RoxygenNote field.

What Looks Good

Author information updated correctly (DESCRIPTION:4-7)
The placeholder person("First", "Last", ...) has been replaced with real team members. The c() wrapper for multiple authors is correct R syntax, and the positional person(given, family, , email, role) double-comma convention (skipping middle) is valid.

roxygen2 version update (DESCRIPTION:13 removed, DESCRIPTION:27 added)
Replacing RoxygenNote: 7.3.2 with Config/roxygen2/version: 8.0.0 is the correct approach for roxygen2 8.x. RoxygenNote is auto-generated by older devtools::document() invocations; the Config/ field is the proper key for the newer version.


Suggestions

Title and Description fields are still placeholders (DESCRIPTION:2, DESCRIPTION:8)

Title: What the Package Does (One Line, Title Case)
Description: What the package does (one paragraph).

These should be filled in — R package checks (R CMD check) will warn if they remain as defaults. Fix this →

ORCID identifiers omitted
The original template included comment = c(ORCID = "YOUR-ORCID-ID") as a placeholder. Adding real ORCID IDs for the authors improves scholarly attribution and is a common best practice for academic R packages.

Config/roxygen2/version placement (DESCRIPTION:27)
The field is placed at the very end of the file, after Language. Convention is to keep it near the Roxygen: list(markdown = TRUE) field for readability. Not a functional issue, but worth tidying.


Overall

The core changes are correct and well-formed. The main follow-up item is filling in the Title and Description placeholders to avoid R CMD check warnings.

@d-morrison d-morrison merged commit 260645b into main Jun 5, 2026
5 checks passed
@d-morrison d-morrison deleted the update-desc branch June 5, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant