You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds minimal Air formatter infrastructure via usethis::use_air(). The changes are focused and correct.
.Rbuildignore
Both patterns are correct:
^[\.]?air\.toml$ — matches both air.toml and .air.toml
^\.vscode$ — excludes the IDE directory from the package bundle
air.toml (empty)
An empty file signals Air is in use and applies all defaults. This is appropriate for now — Air's configuration surface is still limited. The one thing to be aware of: Air will format code using its own defaults (Tidyverse style) when run, which is compatible with the project's .lintr.R since both follow the Tidyverse style guide.
.vscode/settings.json
Enables format-on-save with Air as the default R formatter. Contributors using VSCode/Cursor without the Air extension installed will see a "formatter not found" warning on save. Installing the recommended extension (declared in extensions.json) resolves it, but it may be worth a note in the contributing docs.
History note
The original commit (b1d0aba) accidentally included junit.xml (a local test-output artifact). It was cleaned up in dbef4fc, and .gitignore now covers it — no action needed, just noting it for history cleanliness.
inst/WORDLIST
The word "Air" is not in the WORDLIST, but since "air" is a common English word, spelling::spell_check_package() should not flag it. The +1 line added to WORDLIST in this PR appears to be gh (added in the most recent commit to fix a CI spell-check failure).
Overall: Clean, minimal setup. The PR does exactly what usethis::use_air() is supposed to do and nothing more. No R source changes, no impact on tests or documentation. ✓ Approve.
One optional improvement: add a note to CONTRIBUTING.md (or the relevant docs) that contributors using VSCode should install the Posit.air-vscode extension. Low priority given the extension recommendations file handles it.
This PR adds Air formatter infrastructure via usethis::use_air() and documents it for contributors. Changes are minimal and correct.
.Rbuildignore
Both new patterns are well-formed:
^[\.]?air\.toml$ — correctly matches both air.toml and .air.toml
^\.vscode$ — correctly excludes the IDE directory from the package bundle
air.toml (empty)
An empty file signals Air is in use and applies its defaults (Tidyverse style). Compatible with the project's .lintr.R since both target the same style guide.
.vscode/extensions.json + .vscode/settings.json extensions.json recommends Posit.air-vscode. settings.json enables format-on-save correctly scoped to "[r]" — contributors using other languages won't be affected. Clean.
.github/CONTRIBUTING.Rmd + .github/CONTRIBUTING.md
The Air note is added to the "Code style" section in both the source (.Rmd) and generated (.md) files, keeping them in sync. Good. One minor observation: the section still mentions styler as the style tool ("You can use the styler package to apply these styles"). With Air now configured, it may be worth a follow-up to replace or supplement that guidance with Air, but it's non-blocking.
inst/WORDLIST gh was added to fix a CI spell-check failure. Appropriate.
Overall: Clean, minimal setup. No R source changes, no impact on tests or documentation. The CONTRIBUTING update addresses the suggestion from the previous review pass. ✓ Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting up for https://posit-dev.github.io/air/