Open
Conversation
williamckha
previously approved these changes
Mar 27, 2026
Andrewyx
commented
Mar 28, 2026
…into Andrewyx/uart_flashing
nycrat
reviewed
Apr 8, 2026
Member
nycrat
left a comment
nycrat
left a comment
There was a problem hiding this comment.
Added some comments about adding comments. I'm not too familiar with the ansible or platformio code so perhaps there might be things that I've missed
Comment on lines
+54
to
+55
| sudo raspi-config nonint do_serial_hw 0 | ||
| sudo raspi-config nonint do_serial_cons 1 |
Member
There was a problem hiding this comment.
Perhaps add comment to explain these two lines, very unclear at first read about their purpose
Comment on lines
+31
to
+49
| def set_gpio(pin, value): | ||
| try: | ||
| sysfs_gpio(pin, value) | ||
| except Exception: | ||
| v = "dh" if value == PinState.HIGH else "dl" | ||
| try: | ||
| subprocess.run( | ||
| ["pinctrl", "set", str(pin), "op", v], | ||
| check=True, | ||
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL, | ||
| ) | ||
| except Exception: | ||
| subprocess.run( | ||
| ["raspi-gpio", "set", str(pin), "op", v], | ||
| check=False, | ||
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL, | ||
| ) |
Member
There was a problem hiding this comment.
I would suggest adding comments to this function; it is very unclear in what circumstance sysfs_gpio would throw an exception and what the code does to handle the exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements serial flashing using UART via the RX & TX gpio pins of the raspberry pi. Flashing commands have not been altered from ansible. Updates setup scripts to configure platformio natively on the PI. Furthermore, adds autoflashing so that boot and reset no longer need to be pressed.
Testing Done
Flashing completes successfully. Powerloop must still be verified on a protobot.
Resolved Issues
Resolves #3662
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue