[Cont'd] Improved ball placement from RoboCup 2024#3597
Draft
Apeiros-46B wants to merge 46 commits intoUBC-Thunderbots:masterfrom
Draft
[Cont'd] Improved ball placement from RoboCup 2024#3597Apeiros-46B wants to merge 46 commits intoUBC-Thunderbots:masterfrom
Apeiros-46B wants to merge 46 commits intoUBC-Thunderbots:masterfrom
Conversation
… ball placement go back to aligning when ball is lost
…ld_testing_june_4
… field_testing_june_4
… a wall pickoff is no longer needed
…ld_testing_june_4
…_testing_june_4 # Conflicts: # src/software/ai/hl/stp/play/ball_placement/ball_placement_play_fsm.h
…into ball_placement
…into ball_placement
…into ball_placement # Conflicts: # src/software/ai/hl/stp/play/ball_placement/ball_placement_play_fsm.cpp # src/software/ai/hl/stp/play/ball_placement/ball_placement_play_fsm.h # src/software/ai/hl/stp/play/ball_placement/ball_placement_play_fsm_test.cpp # src/software/ai/hl/stp/tactic/dribble/dribble_tactic.cpp
Apeiros-46B
commented
Feb 11, 2026
Comment on lines
+16
to
+17
| // Subtract b from a, or return 0 if b is larger than a | ||
| static unsigned int subSat(unsigned int a, unsigned int b) |
Member
Author
There was a problem hiding this comment.
Should this be moved to another file?
* Exclude goalie from placing robot selection * Remember setup angle and check alignment in alignDone * Add ballLost check * Move friendly robots out of the way when setting up move tactics
* "fix" robot bumping ball when retreating * check velocity in align guards * remember placing robot ID to prevent oscillation * temporary friendly robot safe zone logic (need to fix later since rn it goes into goals)
* The fix is slightly suboptimal and relies on a hardcoded fix, will investigate better options soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #3447
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue