More fixes for POC rename symbol by timgent · Pull Request #2 · Tuxified/elixir-ls

timgent · 2022-11-10T16:59:18Z

Few more fixes on this:

Other language servers I've used were just returning nil for the version, which seems to have fixed the [coc.nvim] Error on applyEdits: Error: file:///.... changed before apply edit issue I was having before
Find references when on a variable definition also finds the definition itself, so we were getting duplicate entries in the list of edits because of that (causing renames to fail due to overlapping ranges). Just done a Enum.uniq on the list of changes to fix that
For files other than the one you are on it now returns the URI in the correct format (it wasn't working before)

Stuff I think still needs doing:

There's a small bug with ElixirSense where it doesn't find references for a variable if the definition is on the line after the variable name, something like:

cow = 
  "moo"

I've now raised a PR for this on the elixir sense repo - elixir-lsp/elixir_sense#172 - it has been merged now

- Tests for rename prepare functions
- Preparing to rename currently fails for a function defined in another file, so that needs fixing

Things for follow-up PRs:

- Rename module functionality
- Find references (and hence rename) doesn't work when a usage of a variable is in a list comprehension (this is more of an issue with existing Elixir Sense functionality rather than the rename functionality, but it would be nice to fix)

Btw do you have any guidance on testing with VS code? I mostly use Vim, but would like to test things out on VS code too. UPDATE: This seems helpful - https://dragoshmocrii.com/fix-vscode-elixirls-intellisense-for-code-imported-with-use/

* elixir-lsp#673 fix hover bug for * use function_exported to check module be loaded Change-Id: I8e3c3cde067a7d3313422c0a94f4c4a464bd37de * remove rescue and use if instead of nested cond Change-Id: Ia85056971d7333df5d6a7cf6d3a6bd21c87635eb Co-authored-by: zhuzhenfeng.code <zhuzhenfeng.code@bytedance.com>

compatibility improvement: only return variable type and pagination properties when supported by client run evaluate in a stacktrace frame if specified

…r-lsp#675) * add support for terminateThreads request * add support for pause * format

…nto elixir_sense (elixir-lsp#677) * add utility functions for utf8-utf16 conversions * fix numerous cases of incorrect utf16 positions

…lixir-lsp#678) * remove not supported SetExceptionBreakpoints request handler Clients should only call this request if the capability ‘exceptionBreakpointFilters’ returns one or more filters. No way to implement it via :int module * implement function breakpoints * test erlang breakpoints * fix small memory leak when unsetting last breakpoint in file * add more breakpoint tests * make tests more synchronous * add function breakpoints tests * interpret modules * extract and test mfa parsing * run formatter * Update readme * cleanup * extract and test erlang binding processing fix some isses when var is usend more than 10 times add explicite ordering by variable instance discard underscored variables * breakpoint conditions support added do not warn when setting already set breakpoint * update readme * log when expression crashes * add support for conditional function breakpoints * update readme * add support for breakpoint hit condition * readme updated * implement log message * readme updated * add support for terminateThreads request * add support for pause * make continue, next, stepIn, stepout requests conform to DAP 1.51 Fixes elixir-lsp#669 reworks fixes for elixir-lsp#455 * cleanup :int workaround * tests wip * format

* add support for hover and clipboard eval in debugger * use empty string

* fix typo * warn about not supported client options * Add support for debugger completions

…sp#681) * delete duplicated capability * add process messages as debugger variable scope * improve display of keyword variables * add process info as debugger variable scope

…ir-lsp#684) * Suggest an appropriate module name when auto-completing the 'defmodule' snippet * use processed file_path instead of raw file:// uri for determining appropriate module_names * add umbrella_app test to guard against future regressions * special case common Phoenix folders when suggesting module names * fix broken test Some plugin or setting in my editor trimmed extra spaces from the lines but in this case it cause a test to break by changing the cursor position of the auto-completion trigger

* Consistent headers (getting-started section) * Fix wrong header for vscode getting-started page * Removes trailing spaces * Fixes typos

…d rebuild is necessary Fixes elixir-lsp#686

do not return negative numbers as those are forbidden by the LSP properly treat 0 as unknown position add missing handling for positions with column add missing handling for positions as ranges if file the diagnostics refer to is not open fall back to loading it from the file system do not return lines and columns if we cannot load the file Fixes elixir-lsp#695

* check if loading apps is still needed * Revert "check if loading apps is still needed" This reverts commit d03cfe5. * rename function to match what it actually do * extract diagnostic related code * extract common mix.exs code * fix tests

…Symbol provider Fixes elixir-lsp#700

Disable dialyzer and continue Fixes elixir-lsp#540

Path.wildcard is not working on umbrella level

https://github.com/phoenixframework/phoenix/blob/36639c3132a8063f604dade442238875d787d6af/installer/lib/phx_new/web.ex#L45-L56

…xir-lsp#759)

Right now, this change is a no-op, but if and when this change elixir-lsp/elixir_sense#165 lands, this will quiet elixir_sense's logging in the prod environment, which will prevent logspam in lsp buffers when elixir_sense encounters invalid code.

position should trim to the end of the line

This triggers race conditions in elixir compiler Fixes elixir-lsp#763

…ixir-lsp#768) - so, this behavior wasn't working for me in vs-code, so I hopped into the repo to write a failing test, but the test passed right away (🤔) and I'm now seeing the behavior _sometimes_ work and sometimes not in vs-code - conclusion is that the issue is likely in the vs-code extension, but I figured I'd submit a PR with the regression test if it's desired

timgent · 2022-11-13T21:42:47Z

@Tuxified I think this is pretty much ready, though recent changes to the elixir sense dependency seem to have broken things :( I need to take a deeper look into that but let me know if you have any suggestions. Adding the trace argument seems to fix most things, but the test for renaming a function defined in another file is now broken :(

timgent · 2022-11-13T21:55:09Z

Added some test setup bits and it's all working again now 👍

Let me know if you're happy to merge this to get your PR updated, or if it would be easier for me to raise a new PR with the main repo and then I can follow up any comments too. I'm happy either way :)

gofenix and others added 30 commits February 11, 2022 12:11

Add support for variable expansion of evaluate results (elixir-lsp#672)

c5fd13f

compatibility improvement: only return variable type and pagination properties when supported by client run evaluate in a stacktrace frame if specified

Add support for pause and terminateThread requests in debugger (elixi…

58f07d8

…r-lsp#675) * add support for terminateThreads request * add support for pause * format

Fix numerous cases of incorrect utf16 positions returned and passed i…

6057d36

…nto elixir_sense (elixir-lsp#677) * add utility functions for utf8-utf16 conversions * fix numerous cases of incorrect utf16 positions

Add support for hover and clipboard eval in debugger (elixir-lsp#680)

a0e60f1

* add support for hover and clipboard eval in debugger * use empty string

Add support for completions in debugger (elixir-lsp#679)

ba6252f

* fix typo * warn about not supported client options * Add support for debugger completions

Add debugger variable scopes with messages and process info (elixir-l…

99ab6e9

…sp#681) * delete duplicated capability * add process messages as debugger variable scope * improve display of keyword variables * add process info as debugger variable scope

improvements to document symbols provider

1e38db4

bump otp on ci

71fb6fc

unlock otp versions

d57b41f

Misc mkdocs fixes (elixir-lsp#692)

c1a9a5f

* Consistent headers (getting-started section) * Fix wrong header for vscode getting-started page * Removes trailing spaces * Fixes typos

do not consider changes in .elixir-ls and _build dirs when deciding i…

ae40661

…d rebuild is necessary Fixes elixir-lsp#686

fix crash introduced in ff130f3

5af6a3f

add support for OPT 25 dialyzer opts

0da7623

bump elixir sense

cef11ab

add OTP 25 to test matrix

ca81cff

bump github actions

d87d9be

bump version

85cf3cc

fix md formatting

ec1b31c

Build cleanup (elixir-lsp#698)

c100485

* check if loading apps is still needed * Revert "check if loading apps is still needed" This reverts commit d03cfe5. * rename function to match what it actually do * extract diagnostic related code * extract common mix.exs code * fix tests

make function private

27443d4

update changelog (elixir-lsp#697)

37a15ed

wip

e3278b8

update changelog

539ba88

run formatter

60e2df2

When possible return non empty ranges and selection rages in document…

d59b939

…Symbol provider Fixes elixir-lsp#700

Merge branch 'document-symbol-location'

d226e81

lukaszsamson and others added 20 commits October 31, 2022 07:49

Display message and help log if unable to build PLTs

685c2fa

Disable dialyzer and continue Fixes elixir-lsp#540

Add alias as additionalTextEdits (elixir-lsp#722)

e996a38

fix build on elixir 1.11

9e49ac1

fix build on elixir 1.11

699a728

run formatter

75ec61e

run formatter in language_server app

72b4324

Path.wildcard is not working on umbrella level

add Code of conduct

2dd1e00

Add components to Phoenix dirs (elixir-lsp#757)

badf5dc

https://github.com/phoenixframework/phoenix/blob/36639c3132a8063f604dade442238875d787d6af/installer/lib/phx_new/web.ex#L45-L56

Fix test code lens when umbrella app names have the same prefix. (eli…

3c8a6e0

…xir-lsp#759)

bump elixir_sense

3145fef

Improve LSP consistency

93c196f

position should trim to the end of the line

Avoid rapid rebuild in test

aa4dc45

This triggers race conditions in elixir compiler Fixes elixir-lsp#763

bump elixir_sense

b27f68b

bump version

2d3f272

update changelog

cc85d38

add elixir 1.14 to release matrix

1a1baf2

changelog updated

77670d5

Fix rename file version & file paths

4171632

Fix rename issue with duplicate entries when renaming var definition

0df0996

timgent mentioned this pull request Nov 11, 2022

POC for "rename" functionality elixir-lsp/elixir-ls#676

Open

lukaszsamson and others added 4 commits November 12, 2022 16:37

drop support for elixir 1.11

04407d3

Tests for rename prepare and fix rename prepare across multiple files

42c4d30

Merge branch 'master' into poc_rename_symbol_tg

716de9d

Fix rename issues following merge with master

faf8d25

timgent added 2 commits November 15, 2022 21:05

Rename to only rename fn headers of correct arity

fab2032

Simplify get_char_ident fn in rename provider

532bf88

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

More fixes for POC rename symbol#2

More fixes for POC rename symbol#2
timgent wants to merge 127 commits intoTuxified:poc_rename_symbolfrom
timgent:poc_rename_symbol_tg

timgent commented Nov 10, 2022 •

edited

Loading

Uh oh!

timgent commented Nov 13, 2022

Uh oh!

timgent commented Nov 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Comments

Conversation

timgent commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timgent commented Nov 13, 2022

Uh oh!

timgent commented Nov 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

timgent commented Nov 10, 2022 •

edited

Loading