Carpet compatibility #151
Open
Carpet compatibility #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How this works: Carpet's noBlockDamage mixin is searching for ExplosionDamageCalculator#getBlockExplosionResistance as injection point, moonrise completely overwrites the `calculateExplodedPositions` method, causing conflict. Using inject and cancel at head will silently disable this injector, but there's another injection point for the noBlockDamage feature (https://github.com/gnembon/fabric-carpet/blob/master/src/main/java/carpet/mixins/Explosion_optimizedTntMixin.java#L55), this will clear the affectedBlocks list. So Carpet's feature still works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141.
Carpet's noBlockDamage mixin is searching for ExplosionDamageCalculator#getBlockExplosionResistance as injection point, moonrise completely overwrites the
calculateExplodedPositionsmethod, causing conflict. Using inject and cancel at head will silently disable this injector, but there's another injection point for the noBlockDamage feature Carpet/Explosion_optimizedTntMixin#L55, this will clear the affectedBlocks list. So Carpet's feature still works fine.