-
-
Notifications
You must be signed in to change notification settings - Fork 167
feat(build): use tsdown to build the lib
#1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
There is some circular dependency, docs using |
|
@alvarosabu we should check prefixes at |
|
Hi @userquin thanks for taking the time, as always, to help us out here with the Typescript nightmare 🙈 I'd love to better understand the core motivation behind these changes. Are we primarily addressing the I notice we're tackling three different areas simultaneously 😅, which makes it harder to evaluate each change
Regarding the barrel exports, this might have been something we should have addressed in V5. I'm wondering |
This PR includes:
tsdownto build the libsrc/**or**/composables,components,directives,types,utilsandtemplate-compiler-options,unimportandunplugin-vue-componentsnew subpackage exports (not just types) => NOTE: useunimportto auto-import components and directives andunplugin-vue-componentsto auto-import components (on Nuxt the is no need for components)this PR should be breaking:nowutils/template-compiler-optionsnot being exported by@tresjs/core=>@tresjs/core/template-compiler-options: NOTE: added backtemplateCompilerOptionsto the default subpackage export.package.jsoncontent fromdist/index.jsviadefine: included define in the playgroundtsconfig.node.jsonfiles to allow resolve stuff from the correspondingsrc/**files@tresjs/corefromsrcordistroot folders: current version using@tresjs/corefromnode_modules(there is some circular dependency withtresjs/cientosand/or@tresjs/leches)I still need to (maybe @danielroe can help on this 👇 ):
buildstuff: the banner moved to the tsdown config file.TresJSCoreVersionsomewhere, maybe at utils and barrel.import.meta.env.MODEat logger module, failing at dev in the docs: not yet sure why still resolving from rootdistfolder when it should resolve fromsrcroot folder, check import.meta.env.MODE error error below => FIXED: we need to add@tresjs/**tobuild.transpileto avoid interpreting the packages during buildd.tsfiles, not needed => usingtypesVersionsunimportandunplugin-vue-components(this should go to another PR)import.meta.env.MODE error
@tresjs/core subpackage exports
