-
Notifications
You must be signed in to change notification settings - Fork 0
Add performance test model and update pathfinder tests #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - predicate_id | ||
| - predicate_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If predicates are included, qualifiers have to be as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back in
| One or more 'tags' slot values (slot inherited from TestEntity) should generally | ||
| be defined as filters to specify TestAsset membership in a "Block List" collection. | ||
| PathfinderTestCase: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not model closely to TestCase? If TestCase includes input category and id, then I think this should as well, split into source and target as it is in the test asset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add it back in, but from the Test Harness perspective, these are unused fields and redundant in the Test Assets. I'm inclined to leave them out. What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from a test harness perspective, leaving them out is totally fine. I was really only suggesting it for consistency's sake, but the test runners don't make use of those fields at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave them out for now
No description provided.