Skip to content

Conversation

@maximusunc
Copy link
Collaborator

No description provided.

@maximusunc maximusunc requested a review from uhbrar October 22, 2025 15:46
Comment on lines +165 to +166
- predicate_id
- predicate_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If predicates are included, qualifiers have to be as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in

One or more 'tags' slot values (slot inherited from TestEntity) should generally
be defined as filters to specify TestAsset membership in a "Block List" collection.
PathfinderTestCase:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not model closely to TestCase? If TestCase includes input category and id, then I think this should as well, split into source and target as it is in the test asset.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it back in, but from the Test Harness perspective, these are unused fields and redundant in the Test Assets. I'm inclined to leave them out. What are your thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from a test harness perspective, leaving them out is totally fine. I was really only suggesting it for consistency's sake, but the test runners don't make use of those fields at all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave them out for now

@maximusunc maximusunc requested a review from uhbrar October 23, 2025 18:11
@maximusunc maximusunc merged commit 85671ba into main Oct 24, 2025
2 checks passed
@maximusunc maximusunc deleted the updated_pathfinder_and_performance_models branch October 24, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants