Convert flyby camera system to use dynamic allocation with std::vector

[Copilot]

Checklist

• I have added a changelog entry to the CHANGELOG.md file on the branch/fork (if it is an internal change, this is not needed).
• This pull request meets the Coding Conventions standards: https://github.com/MontyTRC89/TombEngine/blob/master/CONTRIBUTING.md#coding-conventions

Links to issue(s) this pull request concerns (if applicable)

N/A

Pull request description

Converts the flyby camera system from using static arrays with a hardcoded limit to dynamic std::vector allocation, removing all hardcoded limits on flyby cameras.

Changes

• TombEngine/Game/spotcam.h:

  • Removed MAX_SPOTCAMS constant (was 1024)
  • Added SPOTCAM_MAX_SEQUENCE_ID constant (256) for sequence number indexing
  • Changed SpotCam, SpotCamRemap, and CameraCnt from static arrays to std::vector

• TombEngine/Game/spotcam.cpp:

  • Updated variable declarations to use std::vector
  • Modified ClearSpotCamSequences() to use clear() method
  • Updated bounds check in GetCameraTransform() to use SPOTCAM_MAX_SEQUENCE_ID

• TombEngine/Specific/level.cpp:

  • Added vector initialization when loading cameras from level data
  • SpotCam is sized to actual camera count from level data
  • SpotCamRemap and CameraCnt are sized to 256 and zero-initialized (indexed by sequence number, unsigned char range 0-255)

Impact

• No hardcoded limit on flyby cameras - supports unlimited cameras
• Memory is allocated dynamically based on actual camera count
• Reduces memory footprint when fewer cameras are used
• Vectors properly initialized with zero values to match original static array behavior
• Maintains backward compatibility with existing level files and save games

Original prompt

There is a limitation on flyby cameras being restricted to 256 count. Please increase this limit to 1024.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[TrainWrack]

@copilot Can we update the SptCams structure so that it doesn't use a static array?

[Copilot]

@copilot Can we update the SptCams structure so that it doesn't use a static array?

Done. The SpotCam structure now uses std::vector instead of static arrays. Changes include:

• Removed MAX_SPOTCAMS constant
• SpotCam, SpotCamRemap, and CameraCnt are now std::vector
• Memory allocated dynamically based on actual camera count
• No hardcoded limit on flyby cameras

See commits d947271, 9416c6a, 22a1fdf, 2079407, and 8c7fc7c.