fix(desktop): drop in-window menu bar + surface real bootstrap errors#362
Merged
Conversation
…tstrap errors Two papercuts found dogfooding the packaged Windows build: - The default Electron File/Edit/View/Window/Help menu renders *inside* the window on Windows/Linux (it never shows on macOS, where menus live in the system bar) — meaningless clutter for a single-window web-UI app. Set a minimal menu on macOS (keeps copy/paste accelerators), none elsewhere. - Workspace bootstrap failures showed 'exited with code unknown' (a null exit code from a spawn failure) instead of the actual reason, which was already sitting in result.stderr (e.g. the 'bash not found, install Git for Windows' hint). Surface the stderr tail in the message. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two papercuts from dogfooding the packaged Windows build:
result.stderr(e.g. the bash-not-found / install-Git-for-Windows hint). Now surfaces the stderr tail.Test plan
npx tsc --noEmitclean,pnpm -F @traderalice/desktop typecheckcleanvitest run src/workspaces/workspace-creatorgreenBoundary touch
Desktop shell + a workspace error message only. No trading/auth/broker/migration logic.
🤖 Generated with Claude Code