Skip to content

fix(ci): serialize E2E runs via repo-wide concurrency mutex #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TortoiseWolfe merged 2 commits into from
May 13, 2026
Merged

fix(ci): serialize E2E runs via repo-wide concurrency mutex #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62a0768
fix(ci): serialize E2E runs via repo-wide concurrency mutex
TurtleWolfe May 13, 2026
b839cd4
fix(e2e): dispatch scroll event after programmatic scrollTop in messa…
TurtleWolfe May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@ on:
workflow_dispatch:

concurrency:
group: e2e-${{ github.ref }}
cancel-in-progress: true
# Repo-wide mutex: every E2E run shares one Supabase project, and concurrent
# runs race each other's beforeAll cleanupOldMessages hooks (run 25769955636
# on 2026-05-13 was cancelled at 60 min after PR #88's run, started 3 min
# later, wiped its data). Serialize across all refs; do not cancel a running
# job to make room for a queued one.
group: e2e-supabase-${{ github.repository }}
cancel-in-progress: false

env:
NEXT_PUBLIC_SUPABASE_URL: ${{ vars.NEXT_PUBLIC_SUPABASE_URL }}
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/messaging/encrypted-messaging.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,7 @@ test.describe('Encrypted Messaging Flow', () => {
.first()
.evaluate((el) => {
el.scrollTop = 0;
el.dispatchEvent(new Event('scroll', { bubbles: true }));
});

// Look for "Load More" button
Expand Down
9 changes: 8 additions & 1 deletion tests/e2e/messaging/messaging-scroll.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,14 @@ test.describe('Messaging Scroll - User Story 2: Scroll Through Messages', () =>
);
const initialInputBox = await messageInput.boundingBox();

// Scroll up in the message thread
// Scroll up in the message thread.
// WebKit does not always fire the scroll event for programmatic scrollTop
// assignments. Dispatch it explicitly so React listeners (e.g.,
// MessageThread's handleScroll at MessageThread.tsx:194) run reliably
// across browsers.
await messageThread.evaluate((el) => {
el.scrollTop = 0;
el.dispatchEvent(new Event('scroll', { bubbles: true }));
});

// Wait for scroll to complete
Expand Down Expand Up @@ -274,6 +279,7 @@ test.describe('Messaging Scroll - User Story 3: Jump to Bottom Button', () => {
// Scroll up more than 500px to trigger button
await messageThread.evaluate((el) => {
el.scrollTop = Math.max(0, el.scrollHeight - el.clientHeight - 600);
el.dispatchEvent(new Event('scroll', { bubbles: true }));
});

await waitForUIStability(page);
Expand Down Expand Up @@ -320,6 +326,7 @@ test.describe('Messaging Scroll - User Story 3: Jump to Bottom Button', () => {
// Scroll up to trigger button
await messageThread.evaluate((el) => {
el.scrollTop = 0;
el.dispatchEvent(new Event('scroll', { bubbles: true }));
});

await waitForUIStability(page);
Expand Down
Loading