Recreated 99% of ytlite features

[daisuke1227]

I used AI for all of this and it took me hours to do its a mess since downloading youtube videos/audios was the hardest thing ever like this was something else but i got it i bet theres still bugs but im basically there i didnt implement RPC but it would had just been to hard

[Tonwalter888]

@daisuke1227 Can you test all the features and send screenshots here?

You used AI so I'm going to recheck the codes.

[daisuke1227]

of course <33333 ill test everything thank you!

[daisuke1227]

i actually added so much features i cant even test it all

[Tonwalter888]

i actually added so much features i cant even test it all

Just test only the most used features (eg. Downloading, Custom tabs).

[daisuke1227]

this is probably in my eyes the most important feature second to sponserblock that i added https://streamable.com/1yu8fu i'll send a video for sponserblock to

[daisuke1227]

i actually added so much features i cant even test it all

Just test only the most used features (eg. Downloading, Custom tabs).

ohhh okay!

[daisuke1227]

tell me rq what are all of the settings that are super important to test since i know downloading and sponserblock works!?

[Tonwalter888]

tell me rq what are all of the settings that are super important to test since i know downloading and sponserblock works!?

Just wanna know they actually work or not.

[daisuke1227]

tell me rq what are all of the settings that are super important to test since i know downloading and sponserblock works!?

Just wanna know they actually work or not.

they do sponserblock and downloading do work! ill send videos of both in a bit yo have discord itll be easier to send it to you

[Tonwalter888]

@daisuke1227 Things need to improve here.

1. Can you add some icons to the download options?
   (Maybe use YTIIcon and YTIcons to set it)
   
   

2. The SponsorBlock segments are on top of the seekbar. Can you make them stay under the seekbar? (Maybe you can use iSponsorBlock codes)
   

3. Move the SB button to somewhere that's not overriding any buttons.
   

4. Can you remove this gap from the dialog?
   

And lastly, the icons are missing. I'll add them after you fixed these.

[daisuke1227]

@daisuke1227 Things need to improve here.

1. Can you add some icons to the download options?
   (Maybe use YTIIcon and YTIcons to set it)
   
   
2. The SponsorBlock segments are on top of the seekbar. Can you make them stay under the seekbar? (Maybe you can use iSponsorBlock codes)
   
3. Move the SB button to somewhere that's not overriding any buttons.
   
4. Can you remove this gap from the dialog?
   

And lastly, the icons are missing. I'll add them after you fixed these.

doing that right now thank you so much for the feedback >~<

[Tonwalter888]

@daisuke1227 And also add support to download 2K and 4K videos. (Use webM)

[daisuke1227]

@daisuke1227 And also add support to download 2K and 4K videos.

i did add 4K/2K support!

[Tonwalter888]

I might combine this PR and #49 to v2.0.0

[Tonwalter888]

Can you make the SponsorBlock skip dialog like in YTLite?

[daisuke1227]

Can you make the SponsorBlock skip dialog like in YTLite?

ill do it tomorrow it currently almost 1am and im super exhausted but ill do it thank you for testing!

[Tonwalter888]

Okay, also the download option in flyout menu isn't override with our custom downloading options.

[Tonwalter888]

It looks like YTLite can't do this either, nevermind then.

[daisuke1227]

It looks like YTLite can't do this either, nevermind then.

no i can add it lol :3

[Tonwalter888]

It looks like YTLite can't do this either, nevermind then.

no i can add it lol :3

The download option in flyout menu?

[daisuke1227]

It looks like YTLite can't do this either, nevermind then.

no i can add it lol :3

The download option in flyout menu?

It looks like YTLite can't do this either, nevermind then.

no i can add it lol :3

The download option in flyout menu?

yes and i already have highlights lol look in sponserblock it has the option in the bottom

[daisuke1227]

did this fix all the issues btw?

[Tonwalter888]

did this fix all the issues btw?

Not all of them. I removed some features that don't work and for SponsorBlock I will use #49 instead.

[daisuke1227]

did this fix all the issues btw?

Not all of them. I removed some features that don't work and for SponsorBlock I will use #49 instead.

thank you ill keep testing were getting super far and i need to fix downloading >:( its still kinda bugged

[Tonwalter888]

@daisuke1227 Can you use this icon for copy the logs?

[Tonwalter888]

@daisuke1227 Also remove the "requries FFmpeg" descriptions and the "DSD" option out.

[Tonwalter888]

When I choose webM, why is it download as .mkv not webM? Also I can’t scroll to use other share options in the dialog.

[Tonwalter888]

@daisuke1227 I added download feature with some bugs fixed, there are some more features I wanted from this PR.