workflow: remove neofetch from arch builds since it got offically removed in the repos

Author: Toni500github

.github/workflows/makefile.yml

@@ -162,7 +162,7 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Install the packages
-      run: pacman -Syyu git sudo base-devel fakeroot pkgconf tree neofetch --noconfirm --needed
+      run: pacman -Syyu git sudo base-devel fakeroot pkgconf tree --noconfirm --needed
 
     - name: Create a dedicated build user
       run: |
@@ -189,9 +189,6 @@ jobs:
     #- name: Setup SSH session
     #  uses: mxschmitt/action-tmate@v3
 
-    - name: Test neofetch
-      run: neofetch
-
     - name: Test customfetch
       run: customfetch --wrap-lines
 
@@ -204,7 +201,7 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Install the packages
-      run: pacman -Syyu git sudo binutils gdb base-devel fakeroot pkgconf tree neofetch fastfetch --noconfirm --needed
+      run: pacman -Syyu git sudo binutils gdb base-devel fakeroot pkgconf tree fastfetch --noconfirm --needed
 
     - name: get /etc/sudoers
       run: |
@@ -221,9 +218,6 @@ jobs:
     - name: Compile and install
       run: make install DEBUG=1 VENDOR_TEST=1 GUI_APP=0
 
-    - name: Test neofetch
-      run: neofetch
-
     - name: Test fastfetch
       run: fastfetch
 

src/query/linux/user.cpp

@@ -386,7 +386,7 @@ static std::string get_term_version(const std::string_view term_name)
         if (!f.is_open())
             goto skip;
 
-        std::string buffer((std::istreambuf_iterator<char>(f)), std::istreambuf_iterator<char>());
+        std::string buffer(std::istreambuf_iterator<char>{f}, std::istreambuf_iterator<char>{});
         buffer.push_back('\0');
 
         rapidxml::xml_document<> doc;

src/query/linux/utils/dewm.cpp

@@ -191,7 +191,7 @@ std::string get_mate_version()
         return ret;
     }
 
-    std::string buffer((std::istreambuf_iterator<char>(f)), std::istreambuf_iterator<char>());
+    std::string buffer(std::istreambuf_iterator<char>{f}, std::istreambuf_iterator<char>{});
     buffer.push_back('\0');
 
     rapidxml::xml_document<> doc;

src/query/macos/system.cpp

@@ -93,7 +93,7 @@ static System::System_t get_os_infos()
     if (!f.is_open())
         die("Couldn't get MacOS base infos");
 
-    std::string buffer((std::istreambuf_iterator<char>(f)), std::istreambuf_iterator<char>());
+    std::string buffer(std::istreambuf_iterator<char>{f}, std::istreambuf_iterator<char>{});
     buffer.push_back('\0');
 
     rapidxml::xml_document<> doc;