misc: fix untouched UB + add macos to cmake (forgort)

why the fuck until now it wasn't UB?? now I gotta add -fsanitize=address to my debug builds

Author: Toni500github

CMakeLists.txt

@@ -14,13 +14,14 @@ file(GLOB
 	"src/*.cpp"
 	"src/query/linux/*.cpp"
 	"src/query/android/*.cpp"
+	"src/query/macos/*.cpp"
 	"src/query/linux/utils/*.cpp"
 	"src/toml++/toml.cpp")
 
 if(GUI_APP)
-set(TARGET_NAME customfetch-gui)
+	set(TARGET_NAME customfetch-gui)
 else()
-set(TARGET_NAME customfetch)
+	set(TARGET_NAME customfetch)
 endif()
 
 add_executable(${TARGET_NAME} ${SRC})

Makefile

@@ -16,7 +16,8 @@ USE_DCONF	?= 1
 # WAY easier way to build debug and release builds
 ifeq ($(DEBUG), 1)
         BUILDDIR  = build/debug
-        CXXFLAGS := -ggdb3 -Wall -Wextra -Wpedantic -Wno-unused-parameter -DDEBUG=1 $(DEBUG_CXXFLAGS) $(CXXFLAGS)
+        CXXFLAGS := -ggdb3 -Wall -Wextra -Wpedantic -Wno-unused-parameter -DDEBUG=1 -fsanitize=address $(DEBUG_CXXFLAGS) $(CXXFLAGS)
+        LDFLAGS	 += -fsanitize=address
 else
 	# Check if an optimization flag is not already set
 	ifneq ($(filter -O%,$(CXXFLAGS)),)

src/main.cpp

@@ -605,7 +605,7 @@ static bool parseargs(int argc, char* argv[], Config& config, const std::string_
             case 'N':
                 config.args_disable_colors = true; break;
             case 'a':
-                config.overrides["config.ascii-logo-type"] = {.value_type = STR, .string_value = optarg};
+                config.overrides["config.ascii-logo-type"] = {.value_type = STR, .string_value = optarg}; break;
             case 'n':
                 config.args_disable_source = true; break;
             case 'L':

src/parse.cpp

@@ -222,7 +222,7 @@ std::string get_and_color_percentage(const float n1, const float n2, parse_args_
             color = "${" + config.percentage_colors.at(2) + "}";
     }
     else
-{
+    {
         if (result <= 45)
             color = "${" + config.percentage_colors.at(2) + "}";
         else if (result <= 80)

src/query/linux/theme.cpp

@@ -50,6 +50,7 @@ static bool get_xsettings_xfce4(const std::string_view property, const std::stri
 {
     static bool done = false;
     static rapidxml::xml_document<> doc;
+    static std::string buffer;
 
     if (!done)
     {
@@ -58,7 +59,7 @@ static bool get_xsettings_xfce4(const std::string_view property, const std::stri
         if (!f.is_open())
             return false;
 
-        std::string buffer((std::istreambuf_iterator<char>(f)), std::istreambuf_iterator<char>());
+        buffer.assign(std::istreambuf_iterator<char>{f}, std::istreambuf_iterator<char>());
         buffer.push_back('\0');
 
         doc.parse<0>(&buffer[0]);