Update FluxNormaliser for Flex geometry#2347
Merged
Merged
Conversation
lauramurgatroyd
approved these changes
Jun 17, 2026
lauramurgatroyd
left a comment
lauramurgatroyd
left a comment
Member
There was a problem hiding this comment.
Hi @gfardell looks good, just some points for future consideration - possibly can discuss deprecating 'angles' parameters in future
Member
|
Re: the parameter names - could add additional kwarg called 'projection' as well as keeping 'angle'? That's what we did for get_slice etc when we introduced flex geometry |
lauramurgatroyd
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated FluxNormaliser to work with Cone_Flex3D data. Mostly this is the preview not defaulting to
anglesTesting you performed
Added unit test. Ran on cone flex dragon data (see below) and checked no changes to the standard FluxNormaliser notebook in misc.
Related issues/links
closes #2349
Checklist