Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements conditional relighting functionality to optimize room geometry operations by only performing lighting calculations when necessary.
- Adds a
PendingRelightproperty to track rooms that need lighting updates - Introduces a
Rebuildmethod that conditionally performs relighting based on current editor mode - Replaces direct
BuildGeometrycalls withRebuildcalls throughout the codebase to respect the conditional lighting behavior
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TombLib/TombLib/LevelData/RoomGeometry.cs | Removes highQualityLighting parameter from Build method and removes automatic relighting call |
| TombLib/TombLib/LevelData/Room.cs | Adds PendingRelight property and Rebuild method with conditional relighting logic |
| TombLib/TombLib/LevelData/Level.cs | Updates texture removal to use Rebuild method |
| TombLib/TombLib/LevelData/IO/PrjLoader.cs | Updates project loading to use Rebuild method |
| TombLib/TombLib/LevelData/IO/Prj2Loader.cs | Updates project loading to use Rebuild method |
| TombEditor/Undo.cs | Updates undo operations to use appropriate lighting methods |
| TombEditor/Forms/FormTextureRemap.cs | Updates texture remapping to use Rebuild method |
| TombEditor/EditorActions.cs | Updates all geometry operations to use Rebuild with conditional relighting |
| TombEditor/Editor.cs | Adds ShouldRelight property and automatic relighting when switching to lighting mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.