Conversation
- Add theme configuration setting (auto/light/dark) in package.json - Implement VS Code theme detection and configuration reading in extension.ts - Update webview App.tsx to handle theme switching with ag-grid color schemes - Add adaptive styling for light/dark modes including: - Container and controls styling - Error/warning row highlighting - Loading message styling - Create comprehensive test suite: - Extension theme logic tests (theme detection, configuration) - Webview theme logic tests (styling, message handling) - Test infrastructure with proper TypeScript configuration - Organize test files in src/test/ directory structure - Add test scripts for both unit and integration testing - Update dependencies for testing (sinon, jsdom, mocha types) Closes: Dark mode feature request Tests: 14 passing (unit + integration)
feat: Add dark mode support with comprehensive test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.