Provide the ability to link to system simdjson#80
Open
mgorny wants to merge 2 commits intoTkTech:masterfrom
Open
Provide the ability to link to system simdjson#80mgorny wants to merge 2 commits intoTkTech:masterfrom
mgorny wants to merge 2 commits intoTkTech:masterfrom
Conversation
Refactor setup.py in order to avoid declaring Extension() twice. Instead, use a bunch of helper vars that get filled conditionally and create Extension() once. This should reduce the maintenance effort, as well as pave way for more conditions.
Owner
|
Happy to support this as an opt-in. I'm assuming this is for Gentoo, in which case the package maintainer will ensure its linking against the right version? Or do we need to do a sanity in the setup.py? |
Author
|
Yes, we'll handle the right deps ourselves, as well as stripping |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundling a library is a serious sin in our book, so provide the ability to link to the system library. I've also done some refactoring to avoid exponential growth of
Extensioncalls. The default behavior remains the same, so it shouldn't affect existing users.That said, the patch isn't perfect. It still uses the bundled headers instead of system headers but it should be good enough for us.