fix: resolve 6 open issues (Finding hash, ADM ID, hostname dedup, IP filtering, pwd policy, timeout validation)#23
Open
TiltedLunar123 wants to merge 1 commit into
Open
fix: resolve 6 open issues (Finding hash, ADM ID, hostname dedup, IP filtering, pwd policy, timeout validation)#23TiltedLunar123 wants to merge 1 commit into
TiltedLunar123 wants to merge 1 commit into
Conversation
- Add __hash__ to Finding so instances work in sets and dicts (#13) - Use distinct check_id ADM-002 for admin member count finding (#4) - Consolidate duplicate _get_hostname() into core.py (#3) - Filter IPv6 link-local (fe80::) and APIPA (169.254.x.x) from IP list (#12) - Align password policy threshold to CIS 14-char recommendation (#5) - Reject zero and negative --timeout values at argument parsing (#9) - Add 13 tests covering all six fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__hash__toFindingso instances are usable in sets and as dict keysADM-002for the admin member count finding, keepingADM-001for the query-failure case_get_hostname()intocore.py, remove copies fromcli.pyandchecks.pyfe80::) and APIPA (169.254.x.x) addresses from the IP list incollect_system_info--timeoutvalues at argument parsing timeTests
Closes #13, closes #4, closes #3, closes #12, closes #5, closes #9