Mark DebiasConvex non-negative modes as experimental and disable inference outputs#35
Draft
fedemolina wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DebiasConvex(method_non_neg="svd")as an experimental point-estimation heuristic.std=None,inference_valid=False,non_negative_method="svd", and diagnostic fields whenever the non-negative heuristic is requested.method_non_negvalues, includingnnmf, with a clear top-level error because that path changes the model family and is not currently compatible with DebiasConvex debiasing/inference.inference_valid=True.Notes
This PR does not claim inference-valid non-negative DebiasConvex estimation. It adds guardrails so the experimental non-negative point-estimation path is explicit, diagnosable, and does not report standard errors as valid.
Related context: #12
Validation
env PYTHONPATH=src poetry run pytest tests/test_debiasconvex_nonnegative_guardrails.py -qenv PYTHONPATH=src poetry run pytest src/causaltensor/tests/test_synthetic_class.py::TestSyntheticClass::test_dcpr src/causaltensor/tests/test_synthetic_class.py::TestSyntheticClass::test_dcpr_multiple src/causaltensor/tests/test_real_class.py::TestRealClass::test_dcpr -qenv PYTHONPATH=src poetry run pytest tests/test_debiasconvex_nonnegative_guardrails.py src/causaltensor/tests -qpoetry run python -m py_compile src/causaltensor/cauest/DebiasConvex.py tests/test_debiasconvex_nonnegative_guardrails.pytutorials/debiasconvex_nonnegative_guardrails.ipynbfrom repo root and fromtutorials/cwd.