fix: escrow-vault refund restriction, cancel_admin_proposal, saturating_sub for DelegatedPower#732
Open
Userhorlie wants to merge 1 commit into
Open
Conversation
…nkLikeAFounder#708 - escrow-vault: restrict refund_escrow to depositor or admin (ThinkLikeAFounder#693) - common-admin: add cancel_admin_proposal function (ThinkLikeAFounder#694) - governance-token: expose cancel_admin_proposal via common-admin (ThinkLikeAFounder#694) - escrow-vault: expose cancel_admin_proposal via common-admin (ThinkLikeAFounder#694) - governance-token: use saturating_sub for DelegatedPower in burn, delegate (re-delegation), and revoke_delegation (ThinkLikeAFounder#708)
|
@Userhorlie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three security/correctness bugs in one commit.
#693 — escrow-vault: refund_escrow has no caller restriction
Added a check so only the depositor or admin can trigger a refund on an expired escrow. Previously any authenticated address could force-refund any expired escrow.
#694 — common-admin: no cancel_admin_proposal function
Added
cancel_admin_proposaltocommon-adminand exposed it on bothgovernance-tokenandescrow-vault. The current admin can now revoke a pending admin transfer before the 17,280-ledger delay elapses.#708 — governance-token: raw subtraction on DelegatedPower
Replaced raw
-withsaturating_subin all three places that decrementDelegatedPower:burndelegate(re-delegation path)revoke_delegationCloses #693
Closes #694
Closes #708