Fix parameter forwarding in fit_predict and correct progress loss normalisation#14
Open
harens wants to merge 1 commit into
Open
Fix parameter forwarding in fit_predict and correct progress loss normalisation#14harens wants to merge 1 commit into
harens wants to merge 1 commit into
Conversation
Forward caller-provided iterations, batch_size, and verbose values from Interpreter.fit_predict() into the final predict() call. Normalise ContextBuilder progress loss over target predictions while leaving the accumulated training loss and optimisation behaviour unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in inference configuration and training progress reporting.
1. Forward
fit_predictparameters correctlyInterpreter.fit_predict()previously ignored caller-providediterations,batch_size, andverbose, always using hardcoded defaults when callingpredict().This PR forwards those arguments through so runtime behaviour matches the caller’s configuration.
2. Fix progress loss normalisation
Progress loss was previously accumulated as:
This mixes units: the loss is scaled per timestep (
X_.shape[1]), but averaged per sequence (X_.shape[0]), which underestimates the true mean loss.The update instead:
i.e.
batch_size × sequence_length)This makes the reported loss a true per-prediction average.
This change affects only the progress display, not optimisation or model outputs.