Fix keyboard navigation consistency in TUI Update dialog#549
Merged
SorraTheOrc merged 2 commits intomainfrom Mar 11, 2026
Merged
Fix keyboard navigation consistency in TUI Update dialog#549SorraTheOrc merged 2 commits intomainfrom
SorraTheOrc merged 2 commits intomainfrom
Conversation
…pe handlers, add tests and docs Co-authored-by: SorraTheOrc <250240+SorraTheOrc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix navigation issues in update window
Fix keyboard navigation consistency in TUI Update dialog
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Update Work Item dialog had an inconsistent tab order that didn't match its visual layout, and Escape key handlers were missing on the Status and Priority lists, making keyboard navigation unreliable.
Changes
src/tui/controller.tsupdateDialogFieldOrderto follow visual left-to-right column order (Status → Stage → Priority → Comment); was previouslyStage → Status → Priority → CommentopenUpdateDialog()now focusesstatusOptions(leftmost) instead ofstageOptionsKEY_ESCAPEhandlers onupdateDialogStatusOptionsandupdateDialogPriorityOptions— only the stage list alias (updateDialogOptions) and comment textarea had them previously, leaving two lists unable to reliably close the dialog on Escapetests/tui/tui-update-dialog.test.tssrc/tui/components/update-dialog-README.md(new)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh issue create --repo owner/name --title Item without GitHub mapping --body-file - g/tmp-worktree-0/home/REDACTED/work/ContextHub/ContextHub/tests/cli/mock-bin/git ules/.bin/bash bash i/mo�� init g/tmp-worktree-yQILHj/wt 0/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/bash worktree g/tmp-worktree-0/home/REDACTED/work/ContextHub/ContextHub/tests/cli/mock-bin/git odules/npm/node_rev-parse bash(http block)/usr/bin/gh gh issue create --repo owner/name --title Item 1 --body-file - --is-inside-work/home/REDACTED/work/ContextHub/ContextHub/tests/cli/mock-bin/git i/mock-bin/git bash i/mo�� -C /tmp/worklog-test-x872u0/.workloworklog/data e_modules/.bin/bash --orphan worklog/data ode-gyp-bin/bashrev-parse bash(http block)/usr/bin/gh gh issue create --repo owner/name --title Item 2 --body-file - --is-inside-work/home/REDACTED/work/ContextHub/ContextHub/tests/cli/mock-bin/git i/mock-bin/bash /bin/sh i/mo�� git -C '/tmp/worklog-test-x872u0--orphan bash odules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/bash rev-parse O9IRS/wt /usr/local/sbin/rev-parse bash(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>Fix navigation in update window</issue_title>
<issue_description>
Problem statement
Navigation inside the TUI "Update" window is inconsistent for keyboard and mouse users: focus order, selection-list keyboard behaviour, and focus restoration when navigating between items are unclear or broken. This causes friction, accessibility regressions for screen-reader users, and risks accidental data loss when controls unexpectedly steal or lose focus.
Users
Example user stories
Success criteria
Constraints
Existing state
src/tui/controller.tsregistersupdateOverlayclick handlers and contains dialog open/close logic; tests mockupdateOverlayin multiple places.Desired change
Related work
updateOverlayclick handler and tests.Notes / open questions
src/tui/components.Comments on the Issue (you are @copilot in this section)
@SorraTheOrc✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.