feat: improved development workflow by TheTrueAI · Pull Request #59 · TheTrueAI/immermatch

TheTrueAI · 2026-03-02T16:24:56Z

update devcontainer configuration, add .editorconfig, and enhance VSCode settings for improved development workflow

Copilot

Pull request overview

Improves the repository’s local development experience by adding a Makefile-based workflow, standardizing editor settings, and updating devcontainer/VS Code configuration to match the project’s Python + tooling stack.

Changes:

Added a root Makefile for common dev tasks (check/test/lint/format/typecheck/run/install/clean/coverage).
Added editor/workspace tooling (.editorconfig, .vscode/*, devcontainer updates) to streamline formatting, linting, debugging, and setup.
Updated agent/developer documentation to reference the new workflow and clarify “source of truth” locations.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
Makefile	Adds make targets for tests, lint/format, typecheck, run, install, coverage, clean
CLAUDE.md	Adds a quick “make check” alternative for the full check suite
AGENTS.md	Updates workflow/docs, adds “source of truth” annotations, references Makefile
.vscode/settings.json	Adds Copilot Chat instructions, pytest settings, Ruff formatting, terminal auto-approve config
.vscode/launch.json	Adds debug configurations for Streamlit, pytest, and daily_task
.vscode/extensions.json	Recommends Python, Ruff, TOML, and Copilot extensions
.gitignore	Adds ignores for mypy/ruff/pytest caches and htmlcov; selectively commits certain `.vscode` files
.github/copilot/pr-review.prompt.md	Adds a reusable Copilot prompt for addressing PR review comments
.editorconfig	Introduces repo-wide formatting defaults (2-space JSON/YAML/TOML, tabs for Makefile)
.devcontainer/devcontainer.json	Pins Python 3.13 devcontainer and installs dev/test deps + pre-commit hooks

Copilot · 2026-03-02T16:30:00Z

AGENTS.md

 **Output:** A JSON object with score, reasoning, and missing skills.

-**System Prompt:**
+**System Prompt:** *(source of truth: `evaluator_agent.py:SCREENER_SYSTEM_PROMPT`)*


This “source of truth” reference should include the correct module path (immermatch/evaluator_agent.py), not just evaluator_agent.py, so it’s findable from the repo root.

Suggested change

**System Prompt:** *(source of truth: `evaluator_agent.py:SCREENER_SYSTEM_PROMPT`)*

**System Prompt:** *(source of truth: `immermatch/evaluator_agent.py:SCREENER_SYSTEM_PROMPT`)*

Copilot · 2026-03-02T16:30:01Z

AGENTS.md

-source .venv/bin/activate && pytest tests/ -x -q && ruff check --fix . && ruff format --check . && mypy .
+make check      # pytest + ruff lint + ruff format + mypy (the full gate)
+make test        # pytest only
+make lint        # ruff check --fix + ruff format --check


The make lint description here says it runs both ruff check --fix and ruff format --check, but the newly added Makefile’s lint target only runs ruff check --fix. Update this table or the Makefile so they match.

Suggested change

make lint # ruff check --fix + ruff format --check

make lint # ruff check --fix

Copilot · 2026-03-02T16:30:01Z

.vscode/settings.json

+        "source .venv/bin/activate": true,
+        "pip install": true,
+        "cat": true,
+        "head": true,
+        "tail": true,
+        "grep": true,
+        "find": true,
+        "ls": true,
+        "wc": true,
+        "make": true


chat.tools.terminal.autoApprove includes broad entries like pip install (and generic shell commands like cat/find). In a committed workspace settings file this can approve more than intended (e.g., arbitrary pip install ... invocations). Consider narrowing to safer, exact commands or removing this from the repo-level settings.

Suggested change

"source .venv/bin/activate": true,

"pip install": true,

"cat": true,

"head": true,

"tail": true,

"grep": true,

"find": true,

"ls": true,

"wc": true,

"make": true

"source .venv/bin/activate": true

.vscode/settings.json

Copilot · 2026-03-02T16:30:02Z

Makefile

+
+## Lint with ruff (auto-fix)
+lint:
+	source .venv/bin/activate && ruff check --fix .


The lint target only runs ruff check --fix ., but the docs elsewhere in this PR describe make lint as also running ruff format --check. Either update the lint recipe to include the format check, or adjust the documentation so they stay consistent.

Suggested change

source .venv/bin/activate && ruff check --fix .

source .venv/bin/activate && ruff check --fix . && ruff format --check .

Copilot · 2026-03-02T16:30:02Z

AGENTS.md

 **Output:** A structured JSON summary of the candidate.

-**System Prompt:**
+**System Prompt:** *(source of truth: `search_agent.py:PROFILER_SYSTEM_PROMPT`)*


The “source of truth” reference points to search_agent.py, but in this repo the file lives at immermatch/search_agent.py. Update the path here (and the other similar references below) so readers can jump to the correct file.

Suggested change

**System Prompt:** *(source of truth: `search_agent.py:PROFILER_SYSTEM_PROMPT`)*

**System Prompt:** *(source of truth: `immermatch/search_agent.py:PROFILER_SYSTEM_PROMPT`)*

Copilot · 2026-03-02T16:30:02Z

AGENTS.md

 ### Blocked Job Portals (SerpApi only)

-Jobs from the following portals are discarded during search result parsing (see `search_agent.py:_BLOCKED_PORTALS`):
+Jobs from the following portals are discarded during search result parsing (see `serpapi_provider.py:BLOCKED_PORTALS`):


The reference for blocked portals should include the correct module path (immermatch/serpapi_provider.py:BLOCKED_PORTALS). As written, serpapi_provider.py doesn’t exist at the repo root.

Suggested change

Jobs from the following portals are discarded during search result parsing (see `serpapi_provider.py:BLOCKED_PORTALS`):

Jobs from the following portals are discarded during search result parsing (see `immermatch/serpapi_provider.py:BLOCKED_PORTALS`):

Copilot · 2026-03-02T16:30:03Z

AGENTS.md


 ## 6. Pydantic Schemas

+*(Source of truth: `models.py` — keep this section in sync when fields change.)*


The “Source of truth” for Pydantic schemas is immermatch/models.py (not models.py at the repo root). Updating this path will keep the docs navigable.

Suggested change

*(Source of truth: `models.py` — keep this section in sync when fields change.)*

*(Source of truth: `immermatch/models.py` — keep this section in sync when fields change.)*

.vscode/settings.json

Copilot · 2026-03-02T16:30:03Z

Makefile

@@ -0,0 +1,46 @@
+.PHONY: check test lint format typecheck run install install-dev clean


coverage is a declared target but missing from the .PHONY list. Add it to avoid surprising behavior if a file named coverage exists in the repo.

Suggested change

.PHONY: check test lint format typecheck run install install-dev clean

.PHONY: check test lint coverage format typecheck run install install-dev clean

- update devcontainer configuration - add .editorconfig - enhance VSCode settings - add Makefile for common tasks - reorganize GitHub prompts

Copilot AI review requested due to automatic review settings March 2, 2026 16:24

Copilot started reviewing on behalf of TheTrueAI March 2, 2026 16:25 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

TheTrueAI force-pushed the add-custom-prompt branch 2 times, most recently from de522c2 to da5d266 Compare March 2, 2026 20:05

feat: improved development workflow

75a8872

- update devcontainer configuration - add .editorconfig - enhance VSCode settings - add Makefile for common tasks - reorganize GitHub prompts

TheTrueAI force-pushed the add-custom-prompt branch from da5d266 to 75a8872 Compare March 2, 2026 20:10

TheTrueAI merged commit 93bc00d into main Mar 2, 2026
4 checks passed

TheTrueAI deleted the add-custom-prompt branch March 2, 2026 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improved development workflow#59

feat: improved development workflow#59
TheTrueAI merged 1 commit intomainfrom
add-custom-prompt

TheTrueAI commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	System Prompt: (source of truth: `evaluator_agent.py:SCREENER_SYSTEM_PROMPT`)
	System Prompt: (source of truth: `immermatch/evaluator_agent.py:SCREENER_SYSTEM_PROMPT`)

	make lint # ruff check --fix + ruff format --check
	make lint # ruff check --fix

	source .venv/bin/activate && ruff check --fix .
	source .venv/bin/activate && ruff check --fix . && ruff format --check .

	System Prompt: (source of truth: `search_agent.py:PROFILER_SYSTEM_PROMPT`)
	System Prompt: (source of truth: `immermatch/search_agent.py:PROFILER_SYSTEM_PROMPT`)

	Jobs from the following portals are discarded during search result parsing (see `serpapi_provider.py:BLOCKED_PORTALS`):
	Jobs from the following portals are discarded during search result parsing (see `immermatch/serpapi_provider.py:BLOCKED_PORTALS`):


		## 6. Pydantic Schemas

		(Source of truth: `models.py` — keep this section in sync when fields change.)

	(Source of truth: `models.py` — keep this section in sync when fields change.)
	(Source of truth: `immermatch/models.py` — keep this section in sync when fields change.)

		@@ -0,0 +1,46 @@
		.PHONY: check test lint format typecheck run install install-dev clean

	.PHONY: check test lint format typecheck run install install-dev clean
	.PHONY: check test lint coverage format typecheck run install install-dev clean

Conversation

TheTrueAI commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants