Skip to content

Improving translations, adding OSM with link tc conf, some err fix#245

Open
hubertgoeuropa wants to merge 14 commits intoTheTransitClock:developfrom
goeuropa:goeuropa
Open

Improving translations, adding OSM with link tc conf, some err fix#245
hubertgoeuropa wants to merge 14 commits intoTheTransitClock:developfrom
goeuropa:goeuropa

Conversation

@hubertgoeuropa
Copy link
Copy Markdown

PR fix some errors like:

  • creating chart error(comma instad dot in decimals)
  • some errors in mysql queries

@wkulesza
Copy link
Copy Markdown

@scrudden
additional comments to mysql fixes:
AvlJsonQuery.java - adding date_add to SQL, otherwise there was a syntax error for MySQL
ChartJsonBuilder.java - decimals were returned as ',' instead of '.'. Not Mysql, but this was handled.
SqlUtils.java - formatting the date for MySQL format.
schAdhByTimeData.jsp - deleting UNIX_TIMESTAMP for MySQL - there was a syntax error or no data was returned

@wkulesza
Copy link
Copy Markdown

@scrudden Sean, we will divide that PR into a couple PRs to make it easier for you to accept. We will add translations, you will migrate and then the remaining ones will follow.

@scrudden
Copy link
Copy Markdown
Member

scrudden commented Jul 22, 2021 via email

// Add early/ontime/late info
if (temporalDifferenceMsec > 0)
str += " (early)";
str += " (wcześniej)";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this result in a Polish only string appearing somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants