Skip to content

[bug] Fix RBCD audit/find tree prefix using shadowed inner ACE index (#23) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p0dalirius wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bug] Fix RBCD audit/find tree prefix using shadowed inner ACE index (#23) #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/mode_audit/RessourceBasedConstrainedDelegations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ func AuditRessourceBasedConstrainedDelegations(ldapHost string, ldapPort int, cr
if err != nil {
return fmt.Errorf("error creating security descriptor: %s", err)
}
for entryIndex, entry := range ntSecurityDescriptor.DACL.Entries {
for aceIndex, ace := range ntSecurityDescriptor.DACL.Entries {
var separator string
if entryIndex < len(ntSecurityDescriptor.DACL.Entries)-1 {
if aceIndex < len(ntSecurityDescriptor.DACL.Entries)-1 {
separator = "├──"
} else {
separator = "└──"
}

sidString := entry.Identity.SID.ToString()
sidString := ace.Identity.SID.ToString()
distingushedName, err := utils.LookupSID(&ldapSession, sidString)

// Format the string depending on if the SID lookup failed or not
Expand Down
6 changes: 3 additions & 3 deletions core/mode_find/RessourceBasedConstrainedDelegations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ func FindRessourceBasedConstrainedDelegations(ldapHost string, ldapPort int, cre
if err != nil {
return fmt.Errorf("error creating security descriptor: %s", err)
}
for entryIndex, entry := range ntSecurityDescriptor.DACL.Entries {
for aceIndex, ace := range ntSecurityDescriptor.DACL.Entries {
var separator string
if entryIndex < len(ntSecurityDescriptor.DACL.Entries)-1 {
if aceIndex < len(ntSecurityDescriptor.DACL.Entries)-1 {
separator = "├──"
} else {
separator = "└──"
}

sidString := entry.Identity.SID.ToString()
sidString := ace.Identity.SID.ToString()
distingushedName, err := utils.LookupSID(&ldapSession, sidString)

// Format the string depending on if the SID lookup failed or not
Expand Down
Loading