Skip to content

From pull request #80, Added VSync support#83

Open
Ilohama wants to merge 11 commits into
TheCherno:masterfrom
Ilohama:master
Open

From pull request #80, Added VSync support#83
Ilohama wants to merge 11 commits into
TheCherno:masterfrom
Ilohama:master

Conversation

@Ilohama

@Ilohama Ilohama commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

No description provided.


void GLContext::SetVsync(const uint& syncInterval)
{
wglSwapIntervalEXT(syncInterval);

@Shimmen Shimmen Apr 6, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the GL backend is intended to work on Windows, Mac, and Linux. This would only work on Windows.

Edit: on the other hand, there is a Windows handle right above. I'm not sure.

@Ilohama

Ilohama commented Apr 6, 2016

Copy link
Copy Markdown
Contributor Author

Yeah, i've seen that wglswap.... is windows only, the other func for linux etc.... is glXswap....
But for now, we target windows and there is no handler for platform.

@TheCherno

Copy link
Copy Markdown
Owner

That's a good point, maybe this does belong in the platform-specific Window class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants