fixed a bug in Orthographic matrix.#131
Open
Berzeger wants to merge 1 commit into
Open
Conversation
|
I realise that this pull request is from a while ago, but the code is actually correct. Yan's code is equivalent to that graphic because whilst he swapped the |
Author
|
The thing is, he didn't swap anything around, he only omitted the minus sign. |
|
Oh, sorry, I was reading the wrong side of the diff. |
Author
|
No harm done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging from this picture: https://www.safaribooksonline.com/library/view/opengl-es-2/9781941222560/images/AspectRatio/OrthographicMatrixDefinition.png, I believe you accidentally flipped the sign at the line I edited.