This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Fix filenames#115
Open
RealGreenDragon wants to merge 1 commit into
Open
Conversation
Seems that filenames are URL-encoded twice (often only some characters, such as parenthesis), so web browsers cannot recognize filenames. This happens when the method 'RedirectDownload()' receive an URL-encoded $FileName. To fix simply URL-decode also the $FileName value.
Owner
|
Redirect download expects the filename (non urlencoded) as it's arguments (iirc i had removed it after noticing the double decoding downloading a file with % on it), if it's urlencoded then it would be a plugin issue (checking if the filename wasn't urldecoded from the link, etc.) or host issue (on it's C-D headers), that can be fixed using force_name on the plugin, or using CheckBack and "fixing" the header manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that filenames are URL-encoded twice (often only some characters, such as parenthesis), so web browsers cannot recognize filenames.
This happens when the method 'RedirectDownload()' receive an URL-encoded $FileName.
To fix simply URL-decode also the $FileName value.