fix(search): escape FTS5 phrase tokens in buildFtsQuery#373
Open
AbelTomato wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thank you for submitting this PR and participating in Tencent Rhino-bird Open-source Training Program! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description | 描述
Fixes FTS5 MATCH query construction in
buildFtsQuery()by escaping user-provided tokens as quoted FTS5 phrases.Previously, embedded double quotes were removed from tokens before building the OR-joined FTS5 query. This could silently alter user input and did not explicitly protect the FTS5 query expression boundary. Although SQL parameters are used, the value passed to
MATCH ?is still parsed by SQLite FTS5 as a query expression, so user input must not be able to change FTS5 query semantics.This PR adds
quoteFts5Phrase()and escapes embedded double quotes by doubling them.buildFtsQuery()now emits only application-controlledORoperators between quoted phrase terms, while user-provided FTS5 operators such asAND,OR,NOT,NEAR,*, and parentheses are treated as text after tokenization.Related Issue | 关联 Issue
Fix #160
Change Type | 修改类型
Self-test Checklist | 自测清单
Additional Notes | 其他说明
Added unit tests for FTS5 phrase quoting and
buildFtsQuery()behavior, covering normal token queries, punctuation-only input, boolean operator tokens, and embedded double quote escaping.Tested with: