Skip to content

perf: replace O(n²) splice with O(n) filter in filterHeartbeatMessages #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuanrengu wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −13
Open

perf: replace O(n²) splice with O(n) filter in filterHeartbeatMessages #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions src/offload/hooks/llm-input-l3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ function getMessageRoleLocal(msg: any): string | undefined {
return msg.role;
}

function setMessageContentLocal(msg: any, newContent: any[]): void {
if (msg.type === "message") {
msg.message.content = newContent;
} else {
msg.content = newContent;
}
}

function collectHeartbeatToolUseIds(msg: any): string[] {
const role = getMessageRoleLocal(msg);
if (role !== "assistant") return [];
Expand All @@ -71,27 +79,37 @@ export function filterHeartbeatMessages(messages: any[], logger: PluginLogger |
for (const id of collectHeartbeatToolUseIds(msg)) heartbeatIds.add(id);
}
if (heartbeatIds.size === 0) return 0;

let removed = 0;
for (let i = messages.length - 1; i >= 0; i--) {
const msg = messages[i];
const kept: any[] = [];

for (const msg of messages) {
const role = getMessageRoleLocal(msg);

if (role === "toolResult" || role === "tool") {
const tcId = msg.toolCallId ?? msg.tool_call_id ?? msg.message?.toolCallId ?? msg.message?.tool_call_id;
if (tcId && heartbeatIds.has(tcId)) { messages.splice(i, 1); removed++; continue; }
}
if (role === "assistant") {
const content = getMessageContentLocal(msg);
if (!Array.isArray(content)) continue;
const beforeLen = content.length;
for (let j = content.length - 1; j >= 0; j--) {
if (isHeartbeatToolUseBlock(content[j])) content.splice(j, 1);
}
if (content.length < beforeLen) {
if (tcId && heartbeatIds.has(tcId)) {
removed++;
if (content.length === 0) messages.splice(i, 1);
continue;
}
} else if (role === "assistant") {
const content = getMessageContentLocal(msg);
if (Array.isArray(content)) {
const filtered = content.filter((block: any) => !isHeartbeatToolUseBlock(block));
if (filtered.length < content.length) {
removed++;
if (filtered.length === 0) continue;
setMessageContentLocal(msg, filtered);
}
}
}

kept.push(msg);
}

messages.length = 0;
for (const msg of kept) messages.push(msg);

return removed;
}

Expand Down