fix: update use-prevent-scroll to fix iOS Safari flickering#232
Open
SimonEggert wants to merge 1 commit intoTemzasse:mainfrom
Open
fix: update use-prevent-scroll to fix iOS Safari flickering#232SimonEggert wants to merge 1 commit intoTemzasse:mainfrom
use-prevent-scroll to fix iOS Safari flickering#232SimonEggert wants to merge 1 commit intoTemzasse:mainfrom
Conversation
SimonEggert
force-pushed
the
fix-ios-safari-flickering
branch
from
9bd3cdb to
11e8069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #231
I've updated the
use-prevent-scroll.tsfile to the most up-to-date version of the upstream library. Unfortunately, it usesgetNonce.tswhich only got introduced a few days ago, so it is not available in@react-aria/utilspackage just yet. I copied it over for now and added a TODO.However, I tried a packed version of this change and could verify that it indeed resolves the flickering mentioned in the above issue. Could you please check if this would be an applicable solution or if anything prevents the update from being made?