Fix the incomplete subtitles bug

README.md

@@ -24,6 +24,16 @@ https://github.com/TejasQ/gen-subs/assets/9947422/bc8df523-b62a-4123-a62d-2df178
 - 🎧 **Multi-modal** - Supports both audio and video files and generates subtitles for each.
 - 📊 **Multi-model** - Choose from a variety of machine learning models ranging from 40MB to >2GB in size. The larger the model, the more accurate the subtitles, but smaller models are also quite capable.
 
+## Installation
+
+To install gen-subs globally, run the following command :
+
+```bash
+npm i -g gen-subs
+```
+
+It's also possible to install it on a per project basis by omitting the -g flag.
+
 ## Usage
 
 You can generate subtitles for any video using the following command:

actions/for.ts

@@ -1,4 +1,5 @@
 import { join } from "path";
+import path from "path";
 import { lstat, readdir, writeFile } from "fs/promises";
 import { mkdirp } from "mkdirp";
 import ora from "ora";
@@ -24,7 +25,7 @@ type Options = {
 };
 
 export async function forAction(relativeTarget: string, options: Options) {
-  const target = relativeTarget.startsWith('/') ? relativeTarget : join(process.cwd(), relativeTarget);
+  const target = path.resolve(relativeTarget);
   const { pathWithoutExtension, fileName } = splitFilePath(target);
   const format = (options.format ?? "srt").toLowerCase()
 

createTextFromAudioFile.ts

@@ -62,6 +62,7 @@ export const createTextFromAudioFile = (
           results.push(result);
         }
       }
+	  results.push(recognizer.finalResult());
       spinner.clear();
       recognizer.free();
       model.free();

extractAudio.ts

@@ -1,14 +1,15 @@
 import ffmpeg from "fluent-ffmpeg";
 import ffmpegInstaller from "@ffmpeg-installer/ffmpeg";
 import { join } from "path";
+import path from "path";
 import { workingDir } from "./util";
 
 ffmpeg.setFfmpegPath(ffmpegInstaller.path);
 
 export function extractAudio(filePath: string): Promise<string> {
   return new Promise((resolve, reject) => {
-    const fileName = filePath.split("/").pop() ?? "";
-    const fileNameWithoutExtension = fileName.split(".")[0];
+    const fileName = path.basename(filePath);
+	const fileNameWithoutExtension = path.basename(filePath , path.extname(fileName));
     const extractedAudioTarget = join(
       workingDir,
       "from-video",

package.json

@@ -37,10 +37,11 @@
     "inquirer": "^9.2.12",
     "mkdirp": "^3.0.1",
     "ora": "^7.0.1",
+    "rimraf": "^5.0.5",
     "subtitle": "^4.2.1",
+    "typescript": "^5.3.3",
     "vosk": "^0.3.39",
     "wav": "^1.0.2",
-    "rimraf": "^5.0.5",
     "yauzl": "^2.10.0"
   },
   "devDependencies": {

processAudio.ts

@@ -1,13 +1,14 @@
 import ffmpeg from "fluent-ffmpeg";
 import ffmpegInstaller from "@ffmpeg-installer/ffmpeg";
 import { join } from "path";
+import path from "path";
 import { workingDir } from "./util";
 
 ffmpeg.setFfmpegPath(ffmpegInstaller.path);
 
 export function processAudio(inputPath: string): Promise<string> {
-  const fileName = inputPath.split("/").pop() ?? "";
-  const fileNameWithoutExtension = fileName.split(".")[0];
+  const fileName = path.basename(inputPath);
+  const fileNameWithoutExtension = path.basename(inputPath , path.extname(fileName));
   const outputPath = join(
     workingDir, "from-video", `${Date.now()}-${fileNameWithoutExtension}.wav`,
   );

splitFilePath.ts

@@ -1,6 +1,8 @@
+import path from "path";
+
 export function splitFilePath(filePath: string) {
   // Extract the base name (the last part of the path)
-  const baseName = filePath.split("/").pop();
+  const baseName = path.basename(filePath);;
 
   if (!baseName) throw new Error("Invalid file path");