Skip to content

Add Skip option; clear surface on render failure#244

Merged
patchzyy merged 1 commit intomainfrom
dev
Mar 25, 2026
Merged

Add Skip option; clear surface on render failure#244
patchzyy merged 1 commit intomainfrom
dev

Conversation

@patchzyy
Copy link
Copy Markdown
Member

@patchzyy patchzyy commented Mar 25, 2026

Summary by CodeRabbit

  • New Features

    • Added a "Skip" button to the 3D Mii rendering setup popup, allowing users to proceed without downloading offline 3D rendering support.
    • Updated instructions to explain the offline 3D rendering download option and skip functionality.
  • Bug Fixes

    • Fixed render surface clearing when 3D rendering encounters errors.
  • UI/UX

    • Adjusted button layout in the 3D Mii rendering setup popup.

@patchzyy patchzyy merged commit ad13b92 into main Mar 25, 2026
2 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2168585e-6fa5-4c77-b7e4-5f044335c8ce

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc2cd5 and 2aa1af2.

📒 Files selected for processing (3)
  • WheelWizard/Views/Patterns/MiiImages/Mii3DRender.axaml.cs
  • WheelWizard/Views/Popups/Generic/MiiRenderingSetupPopup.axaml
  • WheelWizard/Views/Popups/Generic/MiiRenderingSetupPopup.axaml.cs

📝 Walkthrough

Walkthrough

The changes add support for an optional offline 3D Mii rendering flow. Users can now skip this process via a new button in the setup popup. The rendering error handler was enhanced to clear the surface asynchronously on the UI thread, and the popup UI and logic were updated to support both download completion and skip scenarios.

Changes

Cohort / File(s) Summary
Rendering Error Handling
WheelWizard/Views/Patterns/MiiImages/Mii3DRender.axaml.cs
Added asynchronous UI thread invocation to clear the surface when rendering fails, preventing orphaned render buffers during error conditions.
Offline 3D Rendering Popup
WheelWizard/Views/Popups/Generic/MiiRenderingSetupPopup.axaml, WheelWizard/Views/Popups/Generic/MiiRenderingSetupPopup.axaml.cs
Updated popup instructions and messaging to support skipping offline 3D rendering. Added SkipButton, increased button grid columns from 2 to 3, and implemented skip handler logic with _skipRequested flag to prevent skipping during active downloads. Updated BeforeClose() to resolve completion with both download and skip states.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A skip button hops through the UI today,
Offline rendering can wait—or skip away!
Clear surfaces clean when failures appear,
The popup now offers a path crystal clear! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant