Open files with "Show in Amaze" option#4069
Open files with "Show in Amaze" option#4069seelchen wants to merge 6 commits intoTeamAmaze:release/4.0from
Conversation
|
This issue was more complicated than I thought. I tried my best, but I am not very satisfied with my implementation. This PR adds an intent filter for all To resolve the URI from the intents I added a new function which tries to find the file path using the |
7d8927e to
f75ed3e
Compare
|
hi @seelchen, the code looks good to me.
is this the only issue right now? users selecting "open with amaze" on non-files?
I see that you are handling the issue it gracefully (by giving the heads-up to the user). if this works in most cases, we will be good to go! but, create issues for the things that don't work after merging. also, there's a current implementation for the same from AmazeFileUtilities that uses ( |
|
Hi @VishnuSanal, unfortunately I currently don't have time to investigate this further. |
since this PR works well as of now, we'll take it from here. :) |
VishnuSanal
left a comment
There was a problem hiding this comment.
this actually looks really good from my testing. the handling of failure gracefully is cherry on top. I think we can merge it as is.
Description
When users open an arbitrary file, there is now an option "Show in Amaze". Amaze then tries to find the path of the file and navigate to it.
show-in-amaze.mp4
Issue tracker
Fixes #2714
Automatic tests
Manual tests
Devices:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck