Skip to content

Conversation

@hardliner66
Copy link

While thinking about #57, I remembered that its possible to write *.dmp when an unhandled exception occurs. This adds a setting for windows users, that controls if a dump is written or not.

If the exe was built with debug infos (RelWithDebInfo), the dump can be loaded together with the corresponding *.pdb file in WinDbg, which can then be used to further analyze the dump.

Checklist

  • Tested the change ingame
  • Changed no physics that affect existing maps

@SollyBunny
Copy link
Collaborator

I feel like this should be upstreamed

@hardliner66
Copy link
Author

@SollyBunny probably, but because this is a fork of ddnet, github doesn't let me create a fork of this repo and of ddnet at the same time, making it a bit of a pain to work with both. I mostly added it to help with #57, but I might try adding it upstream as well. For upstream I think it would be nice to have something that works on linux too (e.g.: crashpad or something similar), but for that I would need to take more time to look into the whole topic.

@SollyBunny
Copy link
Collaborator

"Forks" are only a github thing, git lets you have as many upstreams as you want

git remote add tater https://github.com/sjrc6/TaterClient-ddnet
git fetch tater
git checkout tater/master
git switch -c tater_feature
git push origin HEAD:tater_feature
git checkout my_ddnet_feature
git pull ddnet master
git push origin

@SollyBunny
Copy link
Collaborator

Chillerdragon has been pushing for easy crash dumps for post mortem debugging, I don't know what that looks like in the head of the maintainers, but make a pr and see it would probably spark some discussion atleast

@hardliner66
Copy link
Author

Yeah, I know that git itself can deal with this, but given the limited implementation I didn't think it was worth the effort.

For upstream it might even make sense to use something more sophisticated (automatic upload, crash Dialog with button to open a new git issue, etc.).

But you're right, having a starting point to spark a discussion would definitely be a good thing. And in the end, having something simple like this might still be better than having nothing at all. I'll create a PR for upstream later when I'm back on PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants