Skip to content

Conversation

@yuechao-qin
Copy link
Collaborator

@yuechao-qin yuechao-qin commented Jan 16, 2026

Description

Added React Compiler support for PublishComponentButton.tsx and DeprecatePublishedComponentButton.tsx by removing unnecessary useCallback and useMemo hooks. The compiler will automatically optimize these components, eliminating the need for manual memoization.

Type of Change

  • Improvement
  • Cleanup/Refactor

Tests

  • Confirm Chrome React Extension shows Memo next to PublishComponentButton.
    • image.png
  • Clicked PublishComponentButton several times in UI with no noticeable adverse symptoms.
    • image.png
    • Received a 404 error, however when copying the payload from developer tools to POST http://localhost:8000/api/published_components/ it worked fine.
    • @maxy-shpfy is there some environment variable I'm missing to be able to publish the component in the UI?
  • Ran npm run validate:test and passed.

Test Steps

  • Click top right Settings button and toggle Published Components Library to be enabled.
  • Click Add Component button on left panel (next to Components text) and select New tab. Select Python.
  • Change the function name from def filter_text to something noticeable/unique. Change the parameters to be str type so that the YAML has a type for the input parameters. Click Save on top right.
  • Expand the User Components to see your added new component and click the blue "i" icon. Select the Publish tab and press the publish button.

Copy link
Collaborator Author

yuechao-qin commented Jan 16, 2026

@yuechao-qin yuechao-qin changed the title short message Refactor Jan 16, 2026
@yuechao-qin yuechao-qin changed the title Refactor Refactor React Compiler - Manage Component - Publish Button Jan 16, 2026
@yuechao-qin yuechao-qin marked this pull request as ready for review January 16, 2026 13:37
@yuechao-qin yuechao-qin requested a review from a team as a code owner January 16, 2026 13:37
@yuechao-qin yuechao-qin changed the title Refactor React Compiler - Manage Component - Publish Button perf: Refactor React Compiler - Manage Component - Publish Button Jan 16, 2026
@graphite-app
Copy link

graphite-app bot commented Jan 19, 2026

Merge activity

  • Jan 19, 9:27 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Jan 19, 9:27 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

Copy link
Collaborator

I'm not sure about the error you ran into with the PublishComponentButton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants