-
-
Notifications
You must be signed in to change notification settings - Fork 563
fix(solid-form): fix AppField rerender when calling field function #1933 #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 931a48c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 931a48c
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
+ Coverage 90.35% 95.28% +4.92%
==========================================
Files 38 4 -34
Lines 1752 106 -1646
Branches 444 7 -437
==========================================
- Hits 1583 101 -1482
+ Misses 149 5 -144
+ Partials 20 0 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crutchcorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes tests and LGTM! Thanks!
Using any Signal inside the
Form.AppFieldrender function causes the entire component to re-run whenever that Signal changes.Below is an example:
Fix
By wrapping it with a
createComponentthis no longer happens.