Skip to content

fix: replace removed Github brand icon for lucide-react v1 compatibility#137

Merged
kordianbruck merged 1 commit intomasterfrom
copilot/fix-failing-tests
Apr 11, 2026
Merged

fix: replace removed Github brand icon for lucide-react v1 compatibility#137
kordianbruck merged 1 commit intomasterfrom
copilot/fix-failing-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

lucide-react v1 dropped all brand icons (including Github), breaking the TypeScript build across three files.

Changes

  • package.json / pnpm-lock.yaml — bump lucide-react from ^0.577.0 to ^1.0.0 (resolves to 1.8.0)
  • src/components/ui/github-icon.tsx — new reusable inline SVG component mirroring the pattern already used for the LinkedIn icon in member.tsx
  • footer.tsx, member.tsx, HomePage.tsx — replace Github import from lucide-react with GithubIcon from the new component
// Before
import { Github } from "lucide-react";
<Github className="w-4 h-4 mr-2" />

// After
import { GithubIcon } from "@/components/ui/github-icon";
<GithubIcon className="w-4 h-4 mr-2" />

lucide-react v1 removed brand icons including Github. Replace usages
in footer.tsx, member.tsx, and HomePage.tsx with a shared GithubIcon
SVG component. Also update lucide-react to ^1.0.0 in package.json and
regenerate pnpm-lock.yaml.

Agent-Logs-Url: https://github.com/TUM-Dev/Website/sessions/21bfc73e-5b9e-45d3-b523-28aa91ad2ac4

Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com>
@kordianbruck kordianbruck marked this pull request as ready for review April 11, 2026 12:15
@kordianbruck kordianbruck merged commit 6377fe1 into master Apr 11, 2026
5 checks passed
@kordianbruck kordianbruck deleted the copilot/fix-failing-tests branch April 11, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants