refactor: 불필요한 변수 및 타입 체크 제거

[AndyH0ng]

This PR applies 5/5 suggestions from code quality AI findings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and accessibility within the FileDropzone component. It refactors state management for clarity, removes unnecessary type checks for callback functions, and improves the handling of ARIA attributes to ensure better compliance with accessibility standards. The changes contribute to a more robust and maintainable codebase.

Highlights

• Code Simplification: Simplified the isBlocked state calculation in FileDropzone.tsx by directly using the disabled prop, removing an unnecessary intermediate variable.
• Redundant Type Check Removal: Removed redundant typeof function checks for onFileSelected and onCancelUpload callbacks, streamlining the component's logic.
• Accessibility Improvement: Updated the aria-disabled attribute to explicitly use string literals ('true' or 'false') for better adherence to ARIA specifications and improved accessibility.

Changelog

• src/components/common/FileDropzone.tsx
  • Removed the isDisabled variable, integrating its logic directly into the isBlocked calculation.
  • Eliminated redundant typeof onFileSelected !== 'function' checks in handleFileChange and handleDrop.
  • Removed the redundant typeof onCancelUpload !== 'function' check in handleCancelUploading.
  • Modified the aria-disabled attribute to output string values ('true' or 'false') instead of boolean.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request applies several fixes suggested by a code quality tool. Most of the changes are good simplifications, removing redundant variables and superfluous type checks for function props that have default values. These are good improvements. However, the change to the aria-disabled attribute is unnecessary, as React correctly handles boolean props for ARIA attributes, making the original code more concise. I've left a suggestion to revert that specific change.