Conversation
There was a problem hiding this comment.
should this be here? and no space in folder name.
There was a problem hiding this comment.
should this be here?
this .gitignore is to ignore the model weight and video files. Should I move this to the root folder's .ignore file?
and no space in folder name.
got it, i will rename with underscore
There was a problem hiding this comment.
Are you using this dockerfile for training?
There was a problem hiding this comment.
No. These are not used. The models/ and utils/ folder are downloaded as is from the yolov7 official repo without any modification. I can go through to remove unnecessary files if it would make the code better.
There was a problem hiding this comment.
Are you training on AWS? We have our own servers to train on.
There was a problem hiding this comment.
(same as above) I didn't do any training. The pretrained model is downloaded from the official repo.
I can go through to remove unnecessary files if it would make the code better.
There was a problem hiding this comment.
Is this your code? If so, I'll look through it a bit more carefully.
There was a problem hiding this comment.
Yes. I have renamed it to yolov7.py
here is the list of files I wrote that important:
yolov7.pycode to run the modelexample_usage.pycode to show how to call the yolov7.py in other codeshuman_detection_node.pyros2 node that uses yolov7.py
so command line opt is no longer required to run model also cleaned up some confusing variable names
* remove all globals * moved all constants to yaml file * fixed typo and added ApproachState
untested
58cc30d to
25aeb7d
Compare
| self.create_timer(1/self.publishing_frequency, self.publish_message) | ||
| self.print_and_log('Human Detection ready...') | ||
|
|
||
| ascii_numbers = r""" |
There was a problem hiding this comment.
Do you really need this three times in the same PR?!
There was a problem hiding this comment.
That's a lot of identical count downs.
d5d4c66 to
a9a6fba
Compare
stevenwaslander
left a comment
There was a problem hiding this comment.
Just some minor cleanup if possible today. Will test on trailbot as is.
There was a problem hiding this comment.
Remove, not relevant
There was a problem hiding this comment.
This is ok, wrong branch, but still useful. A change from trailbot testing.
There was a problem hiding this comment.
I don't think we need this folder, we're not doing any training or w and b logging.
There was a problem hiding this comment.
I don't think we need this folder, we're not doing any google_app engine stuff.
There was a problem hiding this comment.
I don't think we need this folder, we're not doing any aws stuff.
No description provided.