Skip to content

Rewrite CustomFullScreenActivity using Compose#38

Open
MattiasBuelens wants to merge 2 commits intomasterfrom
feature/custom-fullscreen-compose
Open

Rewrite CustomFullScreenActivity using Compose#38
MattiasBuelens wants to merge 2 commits intomasterfrom
feature/custom-fullscreen-compose

Conversation

@MattiasBuelens
Copy link
Copy Markdown
Contributor

No description provided.

@MattiasBuelens MattiasBuelens requested a review from ceyhun-o April 1, 2026 16:19
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: these are coming from Material Symbols.

@ceyhun-o
Copy link
Copy Markdown
Contributor

ceyhun-o commented Apr 3, 2026

If we decide to go ahead with the change on 11.0, does it make sense to have 2 custom fullscreen activities in this sample like suggested on the internal PR?

One with Compose like this, and the other with AppCompatActivity. I think we can even use the same player but add 2 separate fullscreen buttons passing a different activity before calling requestFullscreen()?

@MattiasBuelens
Copy link
Copy Markdown
Contributor Author

@ceyhun-o We decided not to change FullScreenActivity for 11.0. So this PR is just to show how to do a fullscreen overlay with modern Jetpack Compose. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants