Skip to content

Conversation

@johannesmayer
Copy link
Member

PET/MR Simulation Framework for Dynamic Data including Ground Truth information.

johannesmayer added 30 commits July 27, 2021 07:11
print("Storing to {}".format(fname_output))
nib.save(mvf, fname_output)

root_path = '/media/sf_CCPPETMR/TestData/Input/xDynamicSimulation/pDynamicSimulation/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard-coded

Comment on lines +81 to +83
fpath_testdata_prefix = '/media/sf_CCPPETMR/TestData/'
input_fpath_prefix = fpath_testdata_prefix + 'Input/xDynamicSimulation/pDynamicSimulation/'
output_fpath_prefix = fpath_testdata_prefix + 'Output/xDynamicSimulation/pDynamicSimulation/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard coded paths are bad

Comment on lines +256 to +265
// else if (sirf::iequals(param_name, "position"))
// acq.position() = dataFromHandle<float*>(val);
// else if (sirf::iequals(param_name, "read_dir"))
// acq.read_dir() = dataFromHandle<float*>(val);
// else if (sirf::iequals(param_name, "phase_dir"))
// acq.phase_dir() = dataFromHandle<float*>(val);
// else if (sirf::iequals(param_name, "slice_dir"))
// acq.slice_dir() = dataFromHandle<float*>(val);
// else if (sirf::iequals(param_name, "patient_table_position"))
// acq.patient_table_position() = dataFromHandle<float*>(val);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these not read out?

Comment on lines +1944 to +1945
if(combined_img.items() > this->items() )
throw LocalisedException("The number of coilmaps is less than the number of images to which they should be applied to.", __FILE__, __LINE__);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckolbPTB can you enlighten us on why this change has happened.

@paskino paskino self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants