-
Notifications
You must be signed in to change notification settings - Fork 29
PET/MR Simulation #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
PET/MR Simulation #1007
Conversation
…segmentation anyway
…segmentation anyway
| print("Storing to {}".format(fname_output)) | ||
| nib.save(mvf, fname_output) | ||
|
|
||
| root_path = '/media/sf_CCPPETMR/TestData/Input/xDynamicSimulation/pDynamicSimulation/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard-coded
| fpath_testdata_prefix = '/media/sf_CCPPETMR/TestData/' | ||
| input_fpath_prefix = fpath_testdata_prefix + 'Input/xDynamicSimulation/pDynamicSimulation/' | ||
| output_fpath_prefix = fpath_testdata_prefix + 'Output/xDynamicSimulation/pDynamicSimulation/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard coded paths are bad
| // else if (sirf::iequals(param_name, "position")) | ||
| // acq.position() = dataFromHandle<float*>(val); | ||
| // else if (sirf::iequals(param_name, "read_dir")) | ||
| // acq.read_dir() = dataFromHandle<float*>(val); | ||
| // else if (sirf::iequals(param_name, "phase_dir")) | ||
| // acq.phase_dir() = dataFromHandle<float*>(val); | ||
| // else if (sirf::iequals(param_name, "slice_dir")) | ||
| // acq.slice_dir() = dataFromHandle<float*>(val); | ||
| // else if (sirf::iequals(param_name, "patient_table_position")) | ||
| // acq.patient_table_position() = dataFromHandle<float*>(val); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these not read out?
| if(combined_img.items() > this->items() ) | ||
| throw LocalisedException("The number of coilmaps is less than the number of images to which they should be applied to.", __FILE__, __LINE__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckolbPTB can you enlighten us on why this change has happened.
PET/MR Simulation Framework for Dynamic Data including Ground Truth information.