fix(test): flaky failure in "insertion out of order" test#1334
Merged
Conversation
Slot 0 could be randomly picked for rooting, which is too low to block writes to slot 1, causing a ~1/101 spurious failure.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
yewman
approved these changes
Mar 23, 2026
dnut
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had this come up when running unit tests.
The test roots a randomly-picked slot, then expects writes to slot 1 to be rejected. When slot 0 was picked (due to random sampling in unit test), largest_rooted_slot = 0 correctly allows writes to slot 1, failing the assertion. The fix excludes slot 0 from the random range.