Merged
Conversation
…, and minimal test script for debugging
- destroy conns on deinit - basic connection eviction - pass ptr to empty slice instead of null in lsquic_engine_connect - update peer address on packet ingestion
…, and minimal test script for debugging
- destroy conns on deinit - basic connection eviction - pass ptr to empty slice instead of null in lsquic_engine_connect - update peer address on packet ingestion
- Add SendTransaction hook context with decode, deserialize, and sanitize logic - Expose TransactionSender type alias and initWithWire constructor - Add getBlockhashLastValidBlockHeight to SlotTracker - Make getDurableNonce public for use in preflight checks - Move MAX_INSTRUCTION_TRACE_LENGTH to transaction_context module
- Add decodeAndDeserialize tests for base64/base58 encoding and error cases - Add sendTransactionImpl tests for channel dispatch and durable nonce - Add SlotTracker getBlockhashLastValidBlockHeight tests - Add TransactionInfo.initWithWire unit tests - Add SendTransaction serialization and resolveEncoding tests - Make transaction_legacy_example fields public for test access
yewman
force-pushed
the
harnew/quic-txn-sender
branch
4 times, most recently
from
0a501f9 to
bf0b1ca
Compare
…, and minimal test script for debugging
yewman
force-pushed
the
harnew/quic-txn-sender
branch
2 times, most recently
from
8f21ee2 to
fd9175d
Compare
…connection pool and metrics - Replace the comptime-parameterized generic Client with a heap-allocated QuicClient that owns all resources (socket, SSL context, lsquic engine, connection pool, receiver channel). - Use fixed-size connection pool with slot reuse via idle timeout - Improve error handling in packetsOut and stream writes (partial write support) - Improve documentation - Add prometheus metric
- Move timing metrics into receiveTransactions and processTransactions via defer blocks - Make metrics logging interval configurable via log_metrics_interval config option - Add doc comments to receiveTransactions and processTransactions. - Fix test cleanup ordering with proper defer statements and increase test timeout.
…plement-getSignatureStatuses-in-rpc
…cker reference and add send transaction unit test
prestonsn
reviewed
Apr 1, 2026
Contributor
prestonsn
left a comment
prestonsn
left a comment
There was a problem hiding this comment.
Looks good, just some stuff
…n error on decode failure
…ack to the supermajority root instead of our tower's root
…llision and it really has no reason to be hardcoded when the OS will assign a free port.
dnut
requested changes
Apr 2, 2026
prestonsn
previously approved these changes
Apr 2, 2026
…n removing the root slot if our root is older than the supermajority root
…plement-getSignatureStatuses-in-rpc
Guard against committing transactions with total_stake=0 on ticks with no newly frozen slots, which would wipe out valid commitment data from the previous cycle.
…adamw/implement-sendTransaction-in-rpc
dnut
approved these changes
Apr 3, 2026
prestonsn
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
sendTransactionRPC methodImplementation
SendTransactionHookContextforsendTransactionand not yet implementedsimulateTransactionTransactionSenderthroughSendTransactionHookContextRamifications
simulateTransactionportion ofsendTransactionis being left unimplemented untilsimulateTransactionis ready to be implemented.Tests
sendTransactiontests totest_serialize.ziggetSignatureStatuses