Conversation
prestonsn
force-pushed
the
prestonsn/impl-get-supply
branch
from
a09a9a8 to
d6b1cdf
Compare
prestonsn
force-pushed
the
prestonsn/impl-get-program-accounts
branch
from
bed9f49 to
8ae5962
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
prestonsn
force-pushed
the
prestonsn/impl-get-supply
branch
from
2de4b91 to
9262b38
Compare
prestonsn
force-pushed
the
prestonsn/impl-get-program-accounts
branch
2 times, most recently
from
6e00548 to
5291f93
Compare
prestonsn
force-pushed
the
prestonsn/impl-get-supply
branch
2 times, most recently
from
3cab526 to
120e1bd
Compare
prestonsn
force-pushed
the
prestonsn/impl-get-program-accounts
branch
3 times, most recently
from
8d43dd3 to
dfe1dd0
Compare
prestonsn
force-pushed
the
prestonsn/impl-get-supply
branch
3 times, most recently
from
4a2474e to
85c56fd
Compare
prestonsn
commented
Mar 19, 2026
ajw221
previously approved these changes
Mar 19, 2026
Contributor
ajw221
left a comment
ajw221
left a comment
There was a problem hiding this comment.
not hard necessary but just thought I'd point a few things out
ajw221
previously approved these changes
Mar 19, 2026
- Add non-circulating supply data file (.zon) with 110 accounts and 10 withdraw authorities matching Agave v3.1.8 - Add build-time script to decode base58 pubkeys into [32]u8 arrays (avoids comptime branch quota limits) - Implement getSupply handler: scans stake accounts, checks lockup/authority, computes circulating vs non-circulating lamports - Add getSysvar generic helper to account_codec, refactor parseMintAdditionalData to use it - Add isNonCirculatingStake to parse_stake module - Add serialization/deserialization tests for GetSupply requests and responses
prestonsn
force-pushed
the
prestonsn/impl-get-supply
branch
from
2c9eada to
56a328c
Compare
ajw221
previously approved these changes
Mar 20, 2026
dnut
reviewed
Mar 20, 2026
…uction Use a single ArrayList instead of collecting extras separately and concatenating two buffers at the end.
dnut
approved these changes
Mar 24, 2026
InKryption
approved these changes
Mar 24, 2026
Contributor
InKryption
left a comment
InKryption
left a comment
There was a problem hiding this comment.
Approved, just had a question
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
implements [getLargestAccounts](https://solana.com/docs/rpc/http/getlargestaccounts) Adds an in memory data-structure to Rooted.zig to track a leaderboard of the top 20 accounts by lamports. It acts as a materialized view (since sqlite lacks native materialized views). Requires #1304 for circulating and nonCirculating calculations ### Testing Done | Test | Result | Speed | |------|--------|-------| | `getLargestAccounts` (processed, no filter) | Sig and Agave match: same 20 accounts, same order | Sig near-instant vs Agave 30s+ | | `getLargestAccounts` (confirmed, no filter) | Sig and Agave match: same 20 accounts, same order | Sig near-instant vs Agave 30s+ | | `getLargestAccounts` (confirmed, circulating) | Sig returned 20 accounts; Agave failed to respond | Sig near-instant | | `getLargestAccounts` (finalized, circulating) | Sig returned 20 accounts; Agave failed to respond | Sig near-instant | | `getLargestAccounts` (confirmed, nonCirculating) | Sig returned empty list; Agave failed to respond | Sig near-instant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements getSupply
Testing Done
commitment: finalizedcommitment: confirmedcommitment: processedfinalized, exclude: truefinalized, exclude: falseconfirmed, exclude: true