Fix double-width line (DECDWL / ESC #6) fragment positioning#46
Open
epatel wants to merge 1 commit intoSwordfish90:masterfrom
Open
Fix double-width line (DECDWL / ESC #6) fragment positioning#46epatel wants to merge 1 commit intoSwordfish90:masterfrom
epatel wants to merge 1 commit intoSwordfish90:masterfrom
Conversation
The old code inverse-mapped the entire top-left point (margins + column offset), so the painter's scale(2,1) simply recovered the original single-width coordinates. On lines with multiple text fragments (e.g. box-drawing chars + text + box-drawing chars), each fragment was placed at its single-width position but rendered at double width, causing overlaps and gaps. Fix by inverse-mapping only the margin/origin offset and leaving the column position unmapped, so the painter scale correctly doubles it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moveTopLeft(textScale.inverted().map(textArea.topLeft()))inverse-mapped the entire top-left point (margins + column offset), so the painter'sscale(2,1)simply recovered the original single-width coordinatesTest script
Test plan
🤖 Generated with Claude Code