Bugfix stmApp.cpp: double idx++ mis-maps valve status list (+ gvlst trailing comma)

[hubertciebiada]

Problem

Two bugs on the same valve-status path (APP_PRE_GETVLSTATUS / gvlst),
the ESP32 parser and the STM32 builder.

1. ESP32 parser — double idx++ (software_esp32/src/stmApp.cpp)

The loop that reads the valve status list increments the index twice per
iteration, once in the for clause and once in the body:

for (uint8_t idx=0; idx<nActuators; idx++) {
    if ((cmdptr=strchr(ps,','))!=NULL) *cmdptr='\0';
    val8 = atoi(ps);
    actuators[idx].state = (val8 & 0x7f);
    actuators[idx].calibration = (val8>=0x80);
    if (cmdptr!=NULL) ps=cmdptr+1;
    idx++;   // ← extra increment
}

The status of valve k lands in actuators[2*k], and every odd slot is
left stale. With 12 valves the loop runs 6 times and fills slots
0,2,4,6,8,10 only. Observed in practice as phantom CONNECTED entries
at idx 9 and 11 on the /valves list — the mirrored statuses of valves
5 and 6 (5→10, 6→12 overflows, while the parser reads far enough to
smear values into 9/11 as ps walks the string).

This is the same copy-pasted pattern already fixed for the 1-Wire
temps/volts sensor lists in the merged PR #5 — this is the third
instance of it, on the valve list.

2. STM32 builder — wrong index for comma separator (software_stm32/src/communication.cpp)

The response is assembled with the wrong variable in the separator test:

for (uint8_t xx=0; xx<ACTUATOR_COUNT; xx++) {
    memset(sendbuffer,0x0,sizeof(sendbuffer));
    itoa(myvalvemots[xx].status, sendbuffer, 10);
    COMM_SER.print(sendbuffer);
    if (x<ACTUATOR_COUNT-1) COMM_SER.print(",");   // ← x, not xx
}

x is the function-level scratch variable (communication.cpp:175),
assigned from atoi(argptr[0]) by other command handlers; the gvlst
block never sets it and its loop index is xx. With x==0 every
element including the last gets a comma → a trailing comma in the reply.

Verification

• Response format is gvlst <count> <s0>,<s1>,... with one status
  token per valve — see software_stm32/src/communication.cpp:405-410.
  <count> equals the number of tokens, so exactly one idx++ per
  element is correct on the ESP32 side.
• x is never assigned inside the gvlst builder block; xx is the
  loop index, so the separator must key off xx.
• Identical mechanism and fix as PR Bugfix stmApp.cpp : double idx++ skips half of 1-Wire sensors #5, which corrected the same
  double-increment in the temps parser (stmApp.cpp) and the volts
  parser copied from it.

Fix

• stmApp.cpp: remove the redundant idx++ from the parser loop body.
• communication.cpp: use the loop index xx in the separator test.

Two separate commits, one per file/MCU.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Mr14XmEnfZ2kFVhfQzupAg