feat(overall): Add Overall Mode#17
Open
kavekor wants to merge 1 commit into
Open
Conversation
This commit introduces a new "Overall" mode to the Combat Logger. When enabled, all combat data is logged into a single, continuous fight session, which persists until the mode is disabled or the client is closed. This provides users with a way to track their total damage over an entire play session without creating separate entries for each encounter. Key Changes: Overall Mode: Added an "Enable Overall Mode" toggle in the plugin configuration. Implemented logic in FightManager to start, stop, and manage a single overallFight object. Modified addDamage and addTicks to route all data to the overallFight when the mode is active, preventing the creation of new fight sessions. Added startUp and shutDown methods to CombatLoggerPlugin to correctly initialize and terminate the "Overall" mode when RuneLite starts or closes with the setting enabled.
Owner
|
I don't think this should be an option in the settings. There should just always be a drop-down option for Overall in the overlay/sidebar and the user can select it if they want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new "Overall" mode to the Combat Logger. When enabled, all combat data is logged into a single, continuous fight session, which persists until the mode is disabled or the client is closed. This provides users with a way to track their total damage over an entire play session without creating separate entries for each encounter.
Key Changes:
Overall Mode:
Added an "Enable Overall Mode" toggle in the plugin configuration.
Implemented logic in FightManager to start, stop, and manage a single overallFight object.
Modified addDamage and addTicks to route all data to the overallFight when the mode is active, preventing the creation of new fight sessions.
Added startUp and shutDown methods to CombatLoggerPlugin to correctly initialize and terminate the "Overall" mode when RuneLite starts or closes with the setting enabled.